domain: EoL deprecate MakeCallback with domain property
#55034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
domain
avivkeller
force-pushed
the
eol-domain-makecallback
branch
from
78e083d to
646c5d4
Compare
avivkeller
added
semver-major
avivkeller
force-pushed
the
eol-domain-makecallback
branch
from
646c5d4 to
c966a22
Compare
|
😅 I didn't realize how integrated this function was into the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55034 +/- ##
==========================================
- Coverage 88.23% 88.22% -0.02%
==========================================
Files 652 652
Lines 183855 183838 -17
Branches 35856 35847 -9
==========================================
- Hits 162227 162193 -34
- Misses 14909 14911 +2
- Partials 6719 6734 +15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
domainmodule is runtime deprecated, and is already discouraged (Quote "Most developers should not have cause to use this module"). So, I move to EoL deprecate the only-left item from this module that is runtime deprecated.This way, users will be encouraged to move to non-deprecated APIs, one deprecation at a time.
CC @nodejs/tsc per nodejs/Release#1034