Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add message for Ambassadors to promote #56235

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mhdawson
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 11, 2024
@mhdawson mhdawson force-pushed the abassador-message-2 branch from d06ad43 to 0441d8e Compare December 11, 2024 21:05
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

doc/contributing/advocacy-ambassador-program.md Outdated Show resolved Hide resolved
demanding language in issues, discussionis or PRs. A respectful diaglog will
maximize the chances of the outcome you desire.
* If you depend on timely support or an SLA, contract with a company that provides
paid support and will prioritize your issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but important: We should highlight who to contact if a company has a bug and actually needs a support contract.

Copy link
Member Author

@mhdawson mhdawson Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina I agree, but I think we should defer adding a list of companies that will provide support in a follow on PR as I think that might be a more complicated discussion.


* Nobody is paid specifically to answer issues or implement features.
* No company owns/supports Node.js. Most contributions are from individuals
as opposed to organizations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth expanding here: Even if a company does pay their employee to contribute to Node.js, all contributions are individual. Meaning, that once an individual receives a commit bit, that belongs to the individual and not the company. If they change employers their status does not change and granting the commit bit to the individual grants no rights in the project to the company. Just not sure how to say that succinctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell, thanks for the suggestion, added some words, let me know if that is what you had in mind.

available to do so.
* People are volunteering their time to review your PRs and answer questions in
the issues you open. Be mindfull of your asks for their time and acknowledge
the gift of their time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should say something also about the importance of not overwhelming folks with too many issues/PRs in a short period of time, or about maintaining a good comment/response ratio in discussions. Otherwise well intentioned requests can easily become a burden if there's simply an overwhelming volume of things to look at and review.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell that is a good idea, will add some words to try to capture that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@mhdawson
Copy link
Member Author

ran the format-md to make the linter happy and forced pushed.


You can find their contact email in the [`README.md`](../../README.md#tsc-technical-steering-committee).

* @marco-ippolito
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops wrong location

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants