-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add message for Ambassadors to promote #56235
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Signed-off-by: Michael Dawson <[email protected]>
d06ad43
to
0441d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a nit
demanding language in issues, discussionis or PRs. A respectful diaglog will | ||
maximize the chances of the outcome you desire. | ||
* If you depend on timely support or an SLA, contract with a company that provides | ||
paid support and will prioritize your issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but important: We should highlight who to contact if a company has a bug and actually needs a support contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina I agree, but I think we should defer adding a list of companies that will provide support in a follow on PR as I think that might be a more complicated discussion.
|
||
* Nobody is paid specifically to answer issues or implement features. | ||
* No company owns/supports Node.js. Most contributions are from individuals | ||
as opposed to organizations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth expanding here: Even if a company does pay their employee to contribute to Node.js, all contributions are individual. Meaning, that once an individual receives a commit bit, that belongs to the individual and not the company. If they change employers their status does not change and granting the commit bit to the individual grants no rights in the project to the company. Just not sure how to say that succinctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell, thanks for the suggestion, added some words, let me know if that is what you had in mind.
available to do so. | ||
* People are volunteering their time to review your PRs and answer questions in | ||
the issues you open. Be mindfull of your asks for their time and acknowledge | ||
the gift of their time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should say something also about the importance of not overwhelming folks with too many issues/PRs in a short period of time, or about maintaining a good comment/response ratio in discussions. Otherwise well intentioned requests can easily become a burden if there's simply an overwhelming volume of things to look at and review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell that is a good idea, will add some words to try to capture that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Co-authored-by: Matteo Collina <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
ran the format-md to make the linter happy and forced pushed. |
|
||
You can find their contact email in the [`README.md`](../../README.md#tsc-technical-steering-committee). | ||
|
||
* @marco-ippolito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops wrong location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Michael Dawson <[email protected]>
No description provided.