Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add message for Ambassadors to promote #56235
base: main
Are you sure you want to change the base?
doc: add message for Ambassadors to promote #56235
Changes from 1 commit
0441d8e
4cdc743
ccdf5f7
b878a3d
fd2dd58
b92538c
03b8b74
b9d966c
6dc95fa
56a2697
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth expanding here: Even if a company does pay their employee to contribute to Node.js, all contributions are individual. Meaning, that once an individual receives a commit bit, that belongs to the individual and not the company. If they change employers their status does not change and granting the commit bit to the individual grants no rights in the project to the company. Just not sure how to say that succinctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell, thanks for the suggestion, added some words, let me know if that is what you had in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should say something also about the importance of not overwhelming folks with too many issues/PRs in a short period of time, or about maintaining a good comment/response ratio in discussions. Otherwise well intentioned requests can easily become a burden if there's simply an overwhelming volume of things to look at and review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell that is a good idea, will add some words to try to capture that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but important: We should highlight who to contact if a company has a bug and actually needs a support contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina I agree, but I think we should defer adding a list of companies that will provide support in a follow on PR as I think that might be a more complicated discussion.