Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable failure persistance in nargo test fuzzing #6777

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

asterite
Copy link
Collaborator

@asterite asterite commented Dec 11, 2024

Description

Problem

Running nargo test with fuzz tests outputs

proptest: FileFailurePersistence::SourceParallel set, but no source file known

which is just noise.

Summary

To reproduce, have a project with this file:

# src/main.nr
#[test]
fn one(_input: u8) {}

Run nargo test. You get:

[one] Running 1 test function
proptest: FileFailurePersistence::SourceParallel set, but no source file known
[one] Testing one... ok
[one] 1 test passed

With this PR:

[one] Running 1 test function
[one] Testing one... ok
[one] 1 test passed

Additional Context

It seems the default failure persistence is a directory called "proptest-regressions". But even when that directory exists we get the error. I assume here that nargo test never produces proptest regressions and that this PR doesn't break things.

Also, it seems test fuzzing in noir is an undocumented feature?

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.17M
workspace 122.09M
regression_4709 294.72M
ram_blowup_regression 2.44G
private-kernel-tail 208.77M
private-kernel-reset 861.45M
private-kernel-inner 307.68M
parity-root 174.42M

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.522s 7%
regression_4709 0m1.529s 1%
ram_blowup_regression 0m16.779s 1%
private-kernel-tail 0m1.305s 4%
private-kernel-reset 0m8.783s 2%
private-kernel-inner 0m2.673s 13%
parity-root 0m1.128s 8%
noir-contracts 2m48.998s 1%

@asterite asterite requested a review from a team December 11, 2024 20:56
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asterite asterite added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 68ff7bd Dec 12, 2024
64 checks passed
@asterite asterite deleted the ab/nargo-test-proptest-failure branch December 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants