Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs #142

Merged
merged 1 commit into from
Sep 20, 2024
Merged

improve docs #142

merged 1 commit into from
Sep 20, 2024

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Sep 16, 2024

Improves docstrings in the selection classes.


🚀 This description was created by 3b56255

docs: improve docstrings and remove unused code in selection.ts

Summary:

Improves docstrings in selection.ts for clarity and removes unused code.

Key points:

  • Docstring Improvements: Enhanced docstrings for Bitmask class and methods (constructor, from_arrow, to_arrow, set, unset, get, and, or, xor, not).
  • Added explanations for parameters and return values.
  • Clarified behavior of applyCompositeFunctionToTile function regarding NONE operation.
  • Code Cleanup: Removed commented-out code for isBooleanColumnParam function and related docstring.

Generated with ❤️ by ellipsis.dev

Copy link
Collaborator Author

bmschmidt commented Sep 16, 2024

Copy link

@eelegiap eelegiap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator Author

bmschmidt commented Sep 19, 2024

Merge activity

@bmschmidt bmschmidt force-pushed the 09-07-add_tuplemap_class branch from dd9bc11 to cd93751 Compare September 20, 2024 02:54
@bmschmidt bmschmidt changed the base branch from 09-07-add_tuplemap_class to graphite-base/142 September 20, 2024 03:08
@bmschmidt bmschmidt changed the base branch from graphite-base/142 to main September 20, 2024 03:11
@bmschmidt bmschmidt merged commit 00815d5 into main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants