make the tiles on a selection a struct of info, not twinned lists #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bmschmidt and the rest of your teammates on |
This was referenced Sep 16, 2024
Merged
eelegiap
approved these changes
Sep 18, 2024
bmschmidt
force-pushed
the
sort-selections
branch
from
88d83ae to
2d77111
Compare
bmschmidt
force-pushed
the
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
branch
from
b59865f to
6fda8c1
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Merge activity
|
bmschmidt
force-pushed
the
sort-selections
branch
from
2d77111 to
89d917d
Compare
bmschmidt
force-pushed
the
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
branch
from
6fda8c1 to
3c779e2
Compare
| // The match count is the number of matches **per tile**; | ||
| // used to access numbers by index. | ||
| public matchCount?: number; |
There was a problem hiding this comment.
The matchCount property in SelectionTile is optional, but it is always used as a number. It should be initialized to 0 in the constructor to avoid potential undefined errors.
Suggested change
| public matchCount?: number; | |
| public matchCount: number = 0; |
bmschmidt
changed the base branch from
sort-selections
to
graphite-base/143
bmschmidt
force-pushed
the
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
branch
from
3c779e2 to
927fc1c
Compare
| let current_tile_ix = 0; | ||
| for (const match_length of this.match_count) { | ||
| const tile = this.tiles[current_tile_ix]; | ||
| for (const { tile, matchCount } of this.tiles) { |
There was a problem hiding this comment.
Ensure 'matchCount' is defined before using it in destructuring assignments. This applies to other instances like lines 728 and 642.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, selections maintain a list of tiles and a list of how many matches there are in them that are guaranteed to be the same length by code.
It's better to have a list of records where each record contains both of these facts; we'll be using these much more to store sort information in a bit.
refactor: use
SelectionTileinDataSelectionfor tile managementSummary:
Refactor
DataSelectionto useSelectionTilefor managing tiles and match counts, simplifying data handling and preparing for future enhancements.Key points:
DataSelectionto useSelectionTilefor managing tiles and match counts.SelectionTileclass insrc/selection.ts.tilesandmatch_countlists with a single list ofSelectionTileobjects.moveCursorToPoint(),add_or_remove_points(),wrapWithSelectionMetadata().SelectionTile.Generated with ❤️ by ellipsis.dev