popover-bug popover bug resolved (#38)

nonfx · Oct 10, 2024 · 97ddd1a · 97ddd1a
1 parent a79c7f0
commit 97ddd1a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/packages/flow-core/CHANGELOG.md b/packages/flow-core/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 # Change Log
 
+## [2.11.5] - 2024-10-10
+
+### patch changes
+
+- overlay-click event behavior updated
+
 ## [2.11.4] - 2024-10-10
 
 ### patch changes

diff --git a/packages/flow-core/package.json b/packages/flow-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nonfx/flow-core",
-  "version": "2.11.4",
+  "version": "2.11.5",
   "description": "Core package of flow design system",
   "type": "module",
   "module": "dist/flow-core.es.js",

diff --git a/packages/flow-core/src/components/f-popover/f-popover-global.scss b/packages/flow-core/src/components/f-popover/f-popover-global.scss
@@ -113,10 +113,10 @@ f-popover {
 		background-color: var(--color-surface-tertiary);
 	}
 
-	&[open][overlay] {
+	&[open] {
 		&::after {
 			content: "";
-			background-color: #000;
+			background-color: transparent;
 			opacity: 0.5;
 			position: fixed;
 			top: 0px;
@@ -125,5 +125,11 @@ f-popover {
 			left: 0px;
 			z-index: 1;
 		}
+
+		&[overlay] {
+			&::after {
+				background-color: #000;
+			}
+		}
 	}
 }
diff --git a/packages/flow-core/src/components/f-popover/f-popover.ts b/packages/flow-core/src/components/f-popover/f-popover.ts
@@ -377,7 +377,7 @@ export class FPopover extends FRoot {
 	}
 
 	outsideClick = (e: MouseEvent) => {
-		if (this.open && e?.target !== this.targetElement) {
+		if (this.open && e?.target === this) {
 			const rect = this.getBoundingClientRect();
 			const isInsideClick =
 				e.clientX > rect.left &&