feat: Redis made optional #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YoussefLaunchUp is attempting to deploy a commit to the Noodle Team on Vercel. A member of the Team first needs to authorize it. |
ixahmedxi
requested changes
Oct 31, 2023
|
@ixahmedxi removed the newer commites |
Erb3
reviewed
Nov 1, 2023
| @@ -185,6 +185,7 @@ And now you got Auth! | |||
| 6. In the "Connect to your database" section, select "@upstash/redis" | |||
| 7. Copy the url into your `.env` file as `REDIS_URL` key | |||
| 8. Copy the token into your `.env` file as `REDIS_TOKEN` key | |||
| 9. Upstash is only used for ratelimiting, if left empty then ratelimiting will be disabled | |||
There was a problem hiding this comment.
I feel this looks like a step of setting up upstash, since it is in the ordered list. I would probably place it above the ordered list so that people read it before setting up upstash.
ixahmedxi
requested changes
Nov 1, 2023
| @@ -185,6 +185,7 @@ And now you got Auth! | |||
| 6. In the "Connect to your database" section, select "@upstash/redis" | |||
| 7. Copy the url into your `.env` file as `REDIS_URL` key | |||
| 8. Copy the token into your `.env` file as `REDIS_TOKEN` key | |||
| 9. Upstash is only used for ratelimiting, if left empty then ratelimiting will be disabled | |||
There was a problem hiding this comment.
Replace this line with the current content and place it on top of the bullet list, as a note when the user firstly starts reading this section:
> **Note** Upstash is used to provide rate-limiting capabilities to Noodle, which is optional when self hosting as that it's really only needed in the production version.
Erb3
pushed a commit
to Erb3-forked/noodle-legacy
that referenced
this pull request
May 14, 2024
Co-authored-by: Ahmed Elsakaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small change to make Redis (and rate limiting) optional, this is to make local development easier. I updated the contributing doc to reflect this as well. Just leaving the UPSTASH_REDIS_REST_URL empty will lead to skipping rate limiting.