Comment Color Brightness #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> Please see nordtheme/nord#94 (1) for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. References: (1) nordtheme/nord#94 GH-117
svengreb
approved these changes
Mar 25, 2019
This was referenced Apr 3, 2019
Merged
This was referenced Apr 11, 2019
arcticicestudio
added a commit
that referenced
this pull request
Jul 20, 2019
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines in the tree view (2). To adapt to Nord's style and ensure it is still distinguishable from the background when hovering with the mouse, the new brightened comment color based on ` nord3` (GH-118) is used. References: (1) https://code.visualstudio.com/updates/v1_36 (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides GH-145
arcticicestudio
added a commit
that referenced
this pull request
Jul 20, 2019
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines in the tree view (2). To adapt to Nord's style and ensure it is still distinguishable from the background when hovering with the mouse, the new brightened comment color based on ` nord3` (GH-118) is used. References: (1) https://code.visualstudio.com/updates/v1_36 (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides Resolves GH-145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue will implement the increase of the comment color (
nord3) brightness by 10% from a lightness level of ~35% to ~45%.➜ Please see nordtheme/nord#94 for all details about this design change decision.
Before
After