Add basic server smoke test #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2023
nornagon
requested changes
Oct 26, 2023
| @@ -0,0 +1,31 @@ | |||
| import { startServer, waitForEbb } from '../server'; | |||
| import type { Server } from 'http'; | |||
| import request from 'supertest'; | |||
There was a problem hiding this comment.
I feel like we probably don't need an extra dependency to make an HTTP request. Node's built-in fetch should be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic smoke test to make sure the Express server starts (sometimes dependency updates break it).
Supersedes #172