Merge pull request #22 from notifo-io/bugfix/optimizedPendingNotifica…

…tions Optimized PendingNotification Query
notifo-io · Jan 26, 2023 · 84693db · 84693db
2 parents 380b1ea + dee5c88
commit 84693db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -8,7 +8,7 @@
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://notifo.io</PackageProjectUrl>
     <PackageTags>notifo xamarin firebase</PackageTags>
-    <Version>1.2.1-beta1</Version>
+    <Version>1.2.1-beta2</Version>
     <LangVersion>9</LangVersion>
   </PropertyGroup>
 </Project>
diff --git a/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs b/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs
@@ -155,7 +155,9 @@ private async Task<List<UserNotificationDto>> GetPendingNotifications1_0Async(in
         private async Task<List<UserNotificationDto>> GetPendingNotifications1_4Async(int take, DateTime after,
             CancellationToken ct)
         {
-            var result = await Client.Notifications.GetMyDeviceNotificationsAsync(token, after, true, take * 2, ct);
+            // use DeviceIdentifier because Token could change over time and you could miss pending notifications. DeviceIdentifier should be more stable.
+            // take is not returning the exact amount of entries. It's taking the X last entries, then filters for messages that are unseen.
+            var result = await Client.Notifications.GetMyDeviceNotificationsAsync(DeviceIdentifier, after, true, take * 2, ct);
 
             return result.Items;
         }
@@ -416,4 +418,4 @@ public void DidReceiveNotificationResponse(UNNotificationResponse response)
             }
         }
     }
-}
+}