Merge pull request #24 from notifo-io/fix/handleLocalNotifications

await for scheduling all local notifications
notifo-io · Jan 31, 2023 · 8a9d68d · 8a9d68d
2 parents 84693db + 47b0439
commit 8a9d68d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -8,7 +8,7 @@
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://notifo.io</PackageProjectUrl>
     <PackageTags>notifo xamarin firebase</PackageTags>
-    <Version>1.2.1-beta2</Version>
+    <Version>1.2.1-beta3</Version>
     <LangVersion>9</LangVersion>
   </PropertyGroup>
 </Project>
diff --git a/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs b/sdk/Notifo.SDK.Core/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs
@@ -87,10 +87,9 @@ private async Task PullPendingNotificationsAndTrack()
                     continue;
                 }
 
-                // Do not "await" here. Trying to save time because of the 30 sec limit of the notification service extension.
-                // Notifications are pushed as quickly as possible to the ios notification scheduler.
-                // This could be a memory issue if there is a large amount of notifications.
-                ShowLocalNotificationAsync(notification).Forget();
+                // Must be finished before notification extensions contentHandler is called
+                // https://developer.apple.com/forums/thread/108340
+                await ShowLocalNotificationAsync(notification);
             }
 
             if (trackImmediatly != null)