Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final user-facing interface improvements #107

Merged
merged 2 commits into from
Mar 21, 2024

dbft: return an error from constructor if config is invalid

10b4f0e
Select commit
Loading
Failed to load commit list.
Merged

Final user-facing interface improvements #107

dbft: return an error from constructor if config is invalid
10b4f0e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 21, 2024 in 1s

46.66% of diff hit (target 62.76%)

View this Pull Request on Codecov

46.66% of diff hit (target 62.76%)

Annotations

Check warning on line 165 in config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

config.go#L165

Added line #L165 was not covered by tests

Check warning on line 340 in config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

config.go#L340

Added line #L340 was not covered by tests

Check warning on line 347 in config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

config.go#L347

Added line #L347 was not covered by tests

Check warning on line 20 in internal/consensus/consensus.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/consensus/consensus.go#L20

Added line #L20 was not covered by tests

Check warning on line 125 in internal/simulation/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/simulation/main.go#L124-L125

Added lines #L124 - L125 were not covered by tests

Check warning on line 135 in internal/simulation/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/simulation/main.go#L134-L135

Added lines #L134 - L135 were not covered by tests