.golangci.yml: add intrange linter
#3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
reviewed
Sep 3, 2024
carpawell
force-pushed
the
feat/add-for-range-linter
branch
from
b9b75f5
to
eeb7c86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3572 +/- ##
==========================================
- Coverage 85.85% 85.79% -0.06%
==========================================
Files 330 330
Lines 38537 38536 -1
==========================================
- Hits 33085 33063 -22
- Misses 3904 3928 +24
+ Partials 1548 1545 -3 ☔ View full report in Codecov by Sentry. |
carpawell
force-pushed
the
feat/add-for-range-linter
branch
2 times, most recently
from
ee5462c
to
232a518
Compare
AnnaShaleva
approved these changes
Sep 4, 2024
|
BTW, there's a tiny typo in the second commit: |
carpawell
force-pushed
the
feat/add-for-range-linter
branch
from
232a518
to
320d33b
Compare
It checks that go 1.22's range-over-numbers feature is not skipped. Also, fix some warnings it found. Signed-off-by: Pavel Karpy <[email protected]>
It took some time to understand why changing a regular `for` to a `range` one leads to behavior changes; let it be more clear and explicit. Also, a correct code is always better than a correct code with `nolint`. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/add-for-range-linter
branch
from
320d33b
to
f8549a4
Compare
AnnaShaleva
approved these changes
Sep 5, 2024
roman-khimov
approved these changes
Sep 5, 2024
AliceInHunterland
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks that go 1.22's range-over-numbers feature is not skipped. Also, fix some warnings it found.