Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NNS contract #266

Closed
wants to merge 17 commits into from
Closed

Update NNS contract #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
16aaaa6
[#266] nns: Add `admin` to properties
AnnaShaleva Sep 9, 2022
80e5bcb
[#266] nns: Return empty Array from `resolve` instead of Null
AnnaShaleva Sep 9, 2022
53e0e91
[#266] nns: Fix safe methods list
AnnaShaleva Sep 9, 2022
b584d5a
[#266] nns: Return empty Array from getRecords instead of Null
AnnaShaleva Sep 9, 2022
8213ba5
[#266] nns: Fix typo in the method description
AnnaShaleva Sep 9, 2022
b1f5864
[#266] nns: Restrict the maximum number of records with the same type
AnnaShaleva Sep 9, 2022
48c96ec
[#266] nns: Move common code to a separate method
AnnaShaleva Sep 9, 2022
f65bbc0
[#266] nns: Fix CNAME resolution rules
AnnaShaleva Sep 9, 2022
fe266fd
[#266] nns: Remove unused config file
AnnaShaleva Sep 12, 2022
22f2700
[#266] nns: Refactor record-related operations code
AnnaShaleva Sep 13, 2022
e5ad839
[#266] nns: Move common record checking code to a separate function
AnnaShaleva Sep 13, 2022
86d171e
[#266] nns: Accept token ID as an argument for storeRecord
AnnaShaleva Sep 13, 2022
b5d1b61
[#266] nns: Reuse storeRecord for storing SOA record
AnnaShaleva Sep 13, 2022
2d8ba9d
[#266] nns: Move token key creation to a separate function
AnnaShaleva Sep 13, 2022
c2e411c
[#266] nns: reuse existing context in tokenIDFromName
AnnaShaleva Sep 13, 2022
6f49a54
[#266] nns: Keep `isAvailable` in sync with `register`
AnnaShaleva Sep 14, 2022
37d5f56
[#266] nns: Use millisecondsInSeconds constant where appropriate
AnnaShaleva Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nns/nns_contract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,8 @@ func DeleteRecords(name string, typ RecordType) {
// Resolve resolves given name (not more then three redirects are allowed).
func Resolve(name string, typ RecordType) []string {
ctx := storage.GetReadOnlyContext()
return resolve(ctx, nil, name, typ, 2)
res := []string{}
return resolve(ctx, res, name, typ, 2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better unwrap compatibility? nspcc-dev/neo-go#2795, maybe?

}

// GetAllRecords returns an Iterator with RecordState items for the given name.
Expand Down
2 changes: 1 addition & 1 deletion tests/container_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func TestContainerPut(t *testing.T) {
})

c.Invoke(t, stackitem.Null{}, "delete", cnt.id[:], cnt.sig, cnt.token)
cNNS.Invoke(t, stackitem.Null{}, "resolve", "mycnt.neofs", int64(nns.TXT))
cNNS.Invoke(t, stackitem.NewArray([]stackitem.Item{}), "resolve", "mycnt.neofs", int64(nns.TXT))

t.Run("register in advance", func(t *testing.T) {
cnt.value[len(cnt.value)-1] = 10
Expand Down
2 changes: 2 additions & 0 deletions tests/nns_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,4 +380,6 @@ func TestNNSResolve(t *testing.T) {
c.Invoke(t, records, "resolve", "test.com", int64(nns.TXT))
c.Invoke(t, records, "resolve", "test.com.", int64(nns.TXT))
c.InvokeFail(t, "invalid domain name format", "resolve", "test.com..", int64(nns.TXT))
// Empty result.
c.Invoke(t, stackitem.NewArray([]stackitem.Item{}), "resolve", "test.com", int64(nns.CNAME))
}