Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameService: port changes from C# NNS #267

Closed
wants to merge 22 commits into from
Closed

NameService: port changes from C# NNS #267

wants to merge 22 commits into from

Conversation

AnnaShaleva
Copy link
Member

Depends on #266, will be rebased after upstream merge.

This PR includes changes implemented into C# NNS version (https://github.com/neo-project/non-native-contracts/blob/master/src/NameService/NameService.cs):

  1. Domain registration price is dependant on domain name length. By default, short (<5 chars) domain names are available for registration only for committee.

    • This change may affect other neofs services including neofs-adm, so we need to create corresponding issues in the affected repos.
    • Also, the contract storage scheme is changed, so the migration routine is added and we need to create an issue to remove it after the contract update.

  2. Renew overload is added that accepts expiration period as an argument. This change is backwords-compatible.

  3. SetAdmin and Renew events are added.

    • These events may be useful for neofs services, we may create an issue to use them where possible (if needed).

I'm restricted to choose the reviewers via Github interface, thus @roman-khimov, @fyrchik, review, please.

@AnnaShaleva
[nspcc-dev#266] nns: Add admin to properties
16aaaa6 
Follow the https://github.com/neo-project/non-native-contracts/blob/14f43ba8cf169323b61c23a3a701ac77d9a4e3eb/src/NameService/NameService.cs#L69.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Return empty Array from resolve instead of Null
80e5bcb 
In case if no records of the specified type found.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Fix safe methods list
53e0e91 
`getRecord` doesn't exist since
nspcc-dev@6ea4573.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Return empty Array from getRecords instead of Null
b584d5a 
And adjust method usages along the way.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Fix typo in the method description
8213ba5 
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Restrict the maximum number of records with the …
b1f5864 
…same type

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Move common code to a separate method
48c96ec 
Reuse getAllRecords for GetAllRecords.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Fix CNAME resolution rules
f65bbc0 
Do not include CNAME to the resulting list if we're looking for another
record type. If it's CNAME than it must be resolved.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Remove unused config file
fe266fd 
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Refactor record-related operations code
22f2700 
Do not move parts of SetRecord/AddRecord to a separate functions,
it makes the contract code more complicated. Also, improve
documentation a bit.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Move common record checking code to a separate f…
e5ad839 
…unction

Don't repeat it each time.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Accept token ID as an argument for storeRecord
86d171e 
It doesn't save VM opcodes, but allows to keep record key creation
logic in a single place which prevents the code from bugs appearance.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Reuse storeRecord for storing SOA record
b5d1b61 
Less code repeating.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Move token key creation to a separate function
2d8ba9d 
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: reuse existing context in tokenIDFromName
c2e411c 
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Keep isAvailable in sync with register
6f49a54 
If conflicting records '*.domain' are present on new domain
registration, then `isAvailable` should return false for this
domain. Ref.
nspcc-dev@f25296b.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#266] nns: Use millisecondsInSeconds constant where appropr…
37d5f56 
…iate

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#267] nns: Make domain registration price dependant on length
41b5f0c 
Add corresponding migration and bump version along the way.
Port neo-project/non-native-contracts@8ac2b80.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#267] common: Fix typo in the comment
0fe6360 
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#267] nns: Accept expiration period in renew
6ab4a65 
Port neo-project/non-native-contracts#13.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#267] nns: Add SetAdmin event
a21a6a8 
Port neo-project/non-native-contracts#11.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
[nspcc-dev#267] nns: Add Renew event
21bd76e 
Port neo-project/non-native-contracts#31.

Signed-off-by: Anna Shaleva <[email protected]>
@cthulhu-rider cthulhu-rider mentioned this pull request Apr 12, 2023
Merged
12 tasks
@AnnaShaleva AnnaShaleva mentioned this pull request May 24, 2023
Open
roman-khimov pushed a commit that referenced this pull request Oct 31, 2024
@AnnaShaleva @roman-khimov
[#267] common: Fix typo in the comment
59872db 
Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov pushed a commit that referenced this pull request Oct 31, 2024
@AnnaShaleva @roman-khimov
[#267] nns: Add SetAdmin event
99ae3c8 
Port neo-project/non-native-contracts#11.

Signed-off-by: Anna Shaleva <[email protected]>
@roman-khimov roman-khimov mentioned this pull request Oct 31, 2024
Merged
@roman-khimov
Copy link
Member

Replaced by #442.

roman-khimov pushed a commit that referenced this pull request Nov 12, 2024
@AnnaShaleva @roman-khimov
[#267] common: Fix typo in the comment
280a51d 
Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov pushed a commit that referenced this pull request Nov 12, 2024
@AnnaShaleva @roman-khimov
[#267] nns: Add SetAdmin event
bbe36a6 
Port neo-project/non-native-contracts#11.

Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov pushed a commit that referenced this pull request Nov 12, 2024
@AnnaShaleva @roman-khimov
[#267] nns: Add SetAdmin event
c8dcbfc 
Port neo-project/non-native-contracts#11.

Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov pushed a commit that referenced this pull request Nov 12, 2024
@AnnaShaleva @roman-khimov
[#267] nns: Add SetAdmin event
18180d3 
Port neo-project/non-native-contracts#11.

Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik Awaiting requested review from fyrchik

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

@carpawell carpawell Awaiting requested review from carpawell carpawell will be requested when the pull request is marked ready for review carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider will be requested when the pull request is marked ready for review cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaShaleva @roman-khimov