NameService: port changes from C# NNS #267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case if no records of the specified type found. Signed-off-by: Anna Shaleva <[email protected]>
`getRecord` doesn't exist since nspcc-dev@6ea4573. Signed-off-by: Anna Shaleva <[email protected]>
And adjust method usages along the way. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
…same type Signed-off-by: Anna Shaleva <[email protected]>
Reuse getAllRecords for GetAllRecords. Signed-off-by: Anna Shaleva <[email protected]>
Do not include CNAME to the resulting list if we're looking for another record type. If it's CNAME than it must be resolved. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Do not move parts of SetRecord/AddRecord to a separate functions, it makes the contract code more complicated. Also, improve documentation a bit. Signed-off-by: Anna Shaleva <[email protected]>
…unction Don't repeat it each time. Signed-off-by: Anna Shaleva <[email protected]>
It doesn't save VM opcodes, but allows to keep record key creation logic in a single place which prevents the code from bugs appearance. Signed-off-by: Anna Shaleva <[email protected]>
Less code repeating. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
If conflicting records '*.domain' are present on new domain registration, then `isAvailable` should return false for this domain. Ref. nspcc-dev@f25296b. Signed-off-by: Anna Shaleva <[email protected]>
…iate Signed-off-by: Anna Shaleva <[email protected]>
Add corresponding migration and bump version along the way. Port neo-project/non-native-contracts@8ac2b80. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Port neo-project/non-native-contracts#13. Signed-off-by: Anna Shaleva <[email protected]>
Port neo-project/non-native-contracts#11. Signed-off-by: Anna Shaleva <[email protected]>
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #266, will be rebased after upstream merge.
This PR includes changes implemented into C# NNS version (https://github.com/neo-project/non-native-contracts/blob/master/src/NameService/NameService.cs):
Domain registration price is dependant on domain name length. By default, short (<5 chars) domain names are available for registration only for committee.
Renewoverload is added that accepts expiration period as an argument. This change is backwords-compatible.SetAdminandRenewevents are added.I'm restricted to choose the reviewers via Github interface, thus @roman-khimov, @fyrchik, review, please.