Upgrade NeoFS SDK module to the latest revision #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Aug 4, 2023
•
cthulhu-rider
commented
- reopens Upgrade NeoFS SDK module to the latest revision #2449 for testing
|
We can close #2449 then, it'd be better to have testing results in the PR anyway. |
cthulhu-rider
force-pushed
the
upgrade-sdk-latest
branch
from
96ca0e4
to
b11429e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
- Coverage 29.38% 29.24% -0.14%
==========================================
Files 399 399
Lines 30381 30368 -13
==========================================
- Hits 8927 8881 -46
- Misses 20711 20751 +40
+ Partials 743 736 -7
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
approved these changes
Aug 8, 2023
Closes #2442. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, IR healthcheck command failed with unimplemented `neo.fs.v2.netmap.NetmapService`. This was caused by API client implementation in NeoFS SDK RC-10 which called `EndpointInfo` RPC on dial: IR nodes doesn't serve NeoFS API, only IR Control API. As a temp solution, `GetSDKClient` function ignores `Unimplemented` gRPC errors during client dial. Signed-off-by: Leonard Lyubich <[email protected]>
According to #2456, custom placement tests are no longer needed. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
upgrade-sdk-latest
branch
from
b1b2935
to
9674748
Compare
roman-khimov
added a commit
that referenced
this pull request
Aug 15, 2023
fix regression from #2470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.