Feat/use neo-go 0.106.3 features #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2907 +/- ##
==========================================
+ Coverage 23.66% 23.70% +0.03%
==========================================
Files 774 774
Lines 44887 44818 -69
==========================================
- Hits 10623 10622 -1
+ Misses 33418 33349 -69
- Partials 846 847 +1 ☔ View full report in Codecov by Sentry. |
carpawell
force-pushed
the
feat/use-neo-go-0.106.3-features
branch
2 times, most recently
from
2e6d3ce
to
857dbd8
Compare
Adopting neo-go new waiting API functionality. It is a little functional change in the NewEpoch event handling (deposit was sent but not awaited), but it should not be a disadvantage: a silent sending without waiting can confuse when reading logs. `morph/client/Client.Wait` was also dropped as not used. Signed-off-by: Pavel Karpy <[email protected]>
Context is an important part of neo-go client's lifecycle, it is passed at creation stage. Do not use `context.Background`, use a general application one instead. Signed-off-by: Pavel Karpy <[email protected]>
`Reverse` explains it worse that explicit `LE`. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/use-neo-go-0.106.3-features
branch
from
857dbd8
to
939766a
Compare
cthulhu-rider
approved these changes
Aug 7, 2024
roman-khimov
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neofs-adm is not touched to save mental health (#2905 was left). Closes #2902.