Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/use neo-go 0.106.3 features #2907

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Feat/use neo-go 0.106.3 features #2907

merged 3 commits into from
Aug 7, 2024

Commits on Aug 7, 2024

  1. pkg/morph/client: always wait for notary deposits 

    Adopting neo-go new waiting API functionality. It is a little functional change
in the NewEpoch event handling (deposit was sent but not awaited), but it should
not be a disadvantage: a silent sending without waiting can confuse when reading
logs.
`morph/client/Client.Wait` was also dropped as not used.

Signed-off-by: Pavel Karpy <[email protected]>
    @carpawell
    carpawell committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0949541 View commit details
    Browse the repository at this point in the history

  2. node: create neo-go client with a meaningful context 

    Context is an important part of neo-go client's lifecycle, it is passed at
creation stage. Do not use `context.Background`, use a general application one
instead.

Signed-off-by: Pavel Karpy <[email protected]>
    @carpawell
    carpawell committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a46c6ae View commit details
    Browse the repository at this point in the history

  3. pkg/morph/client: make endianness clearer in logs code 

    `Reverse` explains it worse that explicit `LE`.

Signed-off-by: Pavel Karpy <[email protected]>
    @carpawell
    carpawell committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    939766a View commit details
    Browse the repository at this point in the history