Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up account alongside pub key in eacl rules in CLI #2915

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Set up account alongside pub key in eacl rules in CLI #2915

merged 1 commit into from
Aug 14, 2024

Conversation

smallhive
Copy link
Contributor

Closes #2914.

roman-khimov
roman-khimov reviewed Aug 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/acl/extended/create.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/util/acl.go Outdated
@@ -276,7 +277,23 @@ func parseEACLRecord(args []string) (*eacl.Record, error) {
}

eacl.AddFormedTarget(r, role, pubs...)
case "account": // targets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@smallhive smallhive force-pushed the 2914-support-account-based-eacls-in-cli branch from 115ed47 to 91bc0fb Compare August 14, 2024 05:22
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 23.51%. Comparing base (1c1cae7) to head (91bc0fb).
Report is 4 commits behind head on master.

Files Patch % Lines
cmd/neofs-cli/modules/util/acl.go 0.00% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
- Coverage   23.53%   23.51%   -0.02%     
==========================================
  Files         776      776              
  Lines       45273    45318      +45     
==========================================
+ Hits        10656    10658       +2     
- Misses      33770    33814      +44     
+ Partials      847      846       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 8497731 into master Aug 14, 2024
16 of 22 checks passed
@roman-khimov roman-khimov deleted the 2914-support-account-based-eacls-in-cli branch August 14, 2024 16:37
@carpawell carpawell mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support account-based EACLs in CLI
3 participants
@smallhive @roman-khimov @carpawell