cli: Don't print help and don't skip defered funcs on failures
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
- Coverage 23.88% 23.53% -0.35%
==========================================
Files 776 776
Lines 45893 46565 +672
==========================================
- Hits 10961 10960 -1
- Misses 34070 34743 +673
Partials 862 862 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
623-do-not-print-help-on-any-failure
branch
from
85bf87d
to
24ab511
Compare
End-rey
force-pushed
the
623-do-not-print-help-on-any-failure
branch
2 times, most recently
from
b99e708
to
23c2dce
Compare
|
Now, in the |
carpawell
reviewed
Sep 23, 2024
cthulhu-rider
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
still suggest to ref first 3 commits to #2890 #2942 (review)
For all cobra-based programs add custom error with code and cause of error and exit func from programs. Refs #2890. Signed-off-by: Andrey Butusov <[email protected]>
Use `RunE` instead of `Run` and throw an error to main function. Then handle error with custom error handler. Refs #2890. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
623-do-not-print-help-on-any-failure
branch
from
23c2dce
to
0162cb0
Compare
Use `RunE` instead of `Run` and throw an error to main function. Wrap error with `common.WrapError` to specify the status code. Then handle error with custom error handler. Refs #2890. Signed-off-by: Andrey Butusov <[email protected]>
Use `RunE` instead of `Run` and throw an error to main function. Then handle error with custom error handler. Update CHANGELOG.md. Closes #2890. Signed-off-by: Andrey Butusov <[email protected]>
Closes #623. Refs #2890. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
623-do-not-print-help-on-any-failure
branch
from
0162cb0
to
fc291a2
Compare
roman-khimov
approved these changes
Sep 24, 2024
End-rey
added a commit
that referenced
this pull request
Sep 25, 2024
From #2942, error format in `adm` is broken. All errors need to be wrapped up: `fmt.Errorf("Error: %w\n", err)`. Signed-off-by: Andrey Butusov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623, #2890.
In
neofs-cliI add funccommon.WrapErrorthat wrap error tocustom_errors.ExitErrand return it on every error, But I doubt it. Maybe it is necessary to wrap only the first appearance of this error, or vice versa, only the last one.