Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Don't print help and don't skip defered funcs on failures #2942

Merged
merged 5 commits into from
Sep 24, 2024

cmd: silence errors and usage for cobra commands

fc291a2
Select commit
Loading
Failed to load commit list.
Merged

cli: Don't print help and don't skip defered funcs on failures #2942

cmd: silence errors and usage for cobra commands
fc291a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 24, 2024 in 0s

23.53% (-0.35%) compared to a0447ce

View this Pull Request on Codecov

23.53% (-0.35%) compared to a0447ce

Details

Codecov Report

Attention: Patch coverage is 0% with 1432 lines in your changes missing coverage. Please review.

Project coverage is 23.53%. Comparing base (a0447ce) to head (fc291a2).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-adm/internal/modules/storagecfg/root.go 0.00% 106 Missing ⚠️
cmd/neofs-cli/modules/object/util.go 0.00% 88 Missing ⚠️
cmd/neofs-cli/modules/object/range.go 0.00% 33 Missing ⚠️
cmd/neofs-cli/modules/container/create.go 0.00% 31 Missing ⚠️
cmd/neofs-cli/modules/container/get.go 0.00% 31 Missing ⚠️
cmd/neofs-cli/modules/control/shards_set_mode.go 0.00% 31 Missing ⚠️
cmd/neofs-cli/modules/object/hash.go 0.00% 31 Missing ⚠️
cmd/neofs-cli/modules/storagegroup/put.go 0.00% 31 Missing ⚠️
cmd/neofs-cli/modules/object/put.go 0.00% 30 Missing ⚠️
cmd/neofs-cli/modules/container/set_eacl.go 0.00% 29 Missing ⚠️
... and 79 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
- Coverage   23.88%   23.53%   -0.35%     
==========================================
  Files         776      776              
  Lines       45893    46565     +672     
==========================================
- Hits        10961    10960       -1     
- Misses      34070    34743     +673     
  Partials      862      862

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov