metabase: drop almost all of Prm/Res structures #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They: * are present in some methods and not in others * add substantial cognitive overhead for anyone looking * require more code to handle trivial things * can allocate more and more of microobjects creating GC pressure Test wrappers in the same package perfectly suggest what everyone wanted to have in the first place. So this patch is a pure refactoring and doesn't change any behavior, but it drops almost all structures. "Almost" because there are cases where we pass a number of things (mostly as a result) and having some enclosing structure makes some sense there. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
roman-khimov
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3001 +/- ##
==========================================
- Coverage 23.15% 23.05% -0.11%
==========================================
Files 789 789
Lines 58815 58669 -146
==========================================
- Hits 13619 13526 -93
+ Misses 44312 44262 -50
+ Partials 884 881 -3 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Nov 6, 2024
| prm.SetCount(vLimit) | ||
|
|
||
| res, err := db.ListWithCursor(prm) | ||
| addrs, _, err := db.ListWithCursor(int(vLimit), nil) |
There was a problem hiding this comment.
Because that's the type ListPrm had for count.
| // Does not stop on an error if there are more objects to handle requested; | ||
| // returns the first error appeared with a number of deleted objects wrapped. | ||
| func (db *DB) Delete(prm DeletePrm) (DeleteRes, error) { | ||
| func (db *DB) Delete(addrs []oid.Address) (DeleteRes, error) { |
There was a problem hiding this comment.
it was variadic. not sure api has become better. but also does not claim it as a much worse one
There was a problem hiding this comment.
From what I see real users have arrays anyway, so this works fine.
| } | ||
|
|
||
| // DoNotMove removes `MoveIt` mark from the object. | ||
| func (db *DB) DoNotMove(prm DoNotMovePrm) (res DoNotMoveRes, err error) { |
There was a problem hiding this comment.
wow, i had no idea we had this method
roman-khimov
added a commit
that referenced
this pull request
Nov 12, 2024
Mostly similar to #3001, we have a number of Prm/Res structures that make it harder to used engine and trace things going on. But there are some functional changes here as well and also things that go beyond Prm/Res. Overall we get rid of many pointless conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They:
Test wrappers in the same package perfectly suggest what everyone wanted to have in the first place. So this patch is a pure refactoring and doesn't change any behavior, but it drops almost all structures. "Almost" because there are cases where we pass a number of things (mostly as a result) and having some enclosing structure makes some sense there.