Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metabase: drop almost all of Prm/Res structures #3001

Merged
merged 1 commit into from
Nov 7, 2024
Merged

metabase: drop almost all of Prm/Res structures #3001

merged 1 commit into from
Nov 7, 2024

Commits on Nov 6, 2024

  1. metabase: drop almost all of Prm/Res structures 

    They:
 * are present in some methods and not in others
 * add substantial cognitive overhead for anyone looking
 * require more code to handle trivial things
 * can allocate more and more of microobjects creating GC pressure

Test wrappers in the same package perfectly suggest what everyone wanted to
have in the first place. So this patch is a pure refactoring and doesn't
change any behavior, but it drops almost all structures. "Almost" because
there are cases where we pass a number of things (mostly as a result) and
having some enclosing structure makes some sense there.

Signed-off-by: Roman Khimov <[email protected]>
    @roman-khimov
    roman-khimov committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    782005b View commit details
    Browse the repository at this point in the history