api: Add stable marshaling #597
Conversation
cthulhu-rider
force-pushed
the
feature/stable-marshaling
branch
2 times, most recently
from
2185947
to
15a614f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
===========================================
+ Coverage 39.56% 53.27% +13.70%
===========================================
Files 147 164 +17
Lines 17496 19059 +1563
===========================================
+ Hits 6922 10153 +3231
+ Misses 10198 8489 -1709
- Partials 376 417 +41 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
feature/stable-marshaling
branch
5 times, most recently
from
144b8e7
to
7bd816d
Compare
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
api/status/codes.go
Outdated
|
|
||
| // All supported status codes. | ||
| const ( | ||
| OK = 0 |
There was a problem hiding this comment.
have you thought about some helper bit operations here? just to describe why it is 1024, 1025, 1026, 1027 and then 2048
There was a problem hiding this comment.
this is not needed, code is just a code, nobody cares what number is it
api/accounting/encoding.go
Outdated
| fieldDecimalPrecision | ||
| ) | ||
|
|
||
| // MarshaledSize returns size of the Decimal in Protocol Buffers V3 format in |
There was a problem hiding this comment.
is it handmade? there was some concept with code generation, have you considered it? tree things were made with it: https://github.com/nspcc-dev/neofs-node/blob/22259ce755199d6e87331a3b58cc14449a36f69e/pkg/services/tree/types_neofs.pb.go
There was a problem hiding this comment.
have you considered it?
not yet, we need a proper testing 1st (it's coming with this PR). Then we can experiment with codegen
There was a problem hiding this comment.
imo, a generator should have been written first, that is an idea about it. but it is late
They are not comparable. Previously, unit tests could fail. Signed-off-by: Leonard Lyubich <[email protected]>
As they state in the docs. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `MarshalToBytes` and `MarshalToRepeatedBytes` may have encoded data incorrectly. If there was nothing left in the buffer to accommodate the entire array, only the part that could fit was written. Now the functions check that the buffer will actually hold the required bytes, and only then calls built-in `copy`. Corresponding unit tests now pass. Signed-off-by: Leonard Lyubich <[email protected]>
Protocol Buffers V3 has no constants, and they are missing in the generated code as well. To make them easier to access, they are exported manually. Signed-off-by: Leonard Lyubich <[email protected]>
Specific encoding of NeoFS messages is required to implement protocol checksums and signatures. Continues 51fa18f. Signed-off-by: Leonard Lyubich <[email protected]>
This fixes ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z $ golangci-lint run ./... WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` ``` The configuration file is updated according to https://golangci-lint.run/usage/configuration/. Signed-off-by: Leonard Lyubich <[email protected]>
According to https://golangci-lint.run/usage/linters/#govet, `check-shadowing` no longer exists. Now it should be ```yaml govet: disable: [shadow] ``` but `shadow` is disabled by default. Thus, whole `govet` section is not needed anymore. ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z ``` Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/stable-marshaling
branch
from
2e706aa
to
d1a668c
Compare
source code is ready and ready for review. Some tests left