topic/delete cookie and use getIdToken #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshim03
reviewed
Jan 22, 2025
There was a problem hiding this comment.
index.js の CookiesProvider を削除できそうです
threatconnectome/web/src/index.jsx
Line 5 in 2d99a21
またそれを実行すると、 package.json の react-cookie 自体を削除できそうに見えます。問題なさそうなら削除をお願いいたします
|
@mshim03
|
|
@mshim03
|
web/src/services/firebaseApi.js
Outdated
| @@ -6,7 +6,7 @@ import { | |||
| browserSessionPersistence, | |||
| } from "firebase/auth"; | |||
|
|
|||
| import { setAuthToken } from "../slices/auth"; | |||
| // import { setAuthToken } from "../slices/auth"; | |||
| search: location.search, | ||
| message: "Please login to continue.", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
tryLogin()して、エラーならloginページにnavigate、
の処理は消してはいけないと思います。
|
2点修正しました
|
web/src/pages/App/AppPage.jsx
Outdated
| @@ -49,7 +35,7 @@ export function App() { | |||
| } | |||
| }; | |||
| _checkToken(); | |||
| }, [cookies, dispatch, location, navigate, skip, tryLogin]); | |||
| }, [location, navigate, tryLogin]); | |||
There was a problem hiding this comment.
_checkToken()を定義する必要が無くなった気がします。下記のように書けますでしょうか。
useEffect(async () => {
try {
There was a problem hiding this comment.
上記のコードのようにしたところ以下の警告が出ました
Effect callbacks are synchronous to prevent race conditions. Put the async function inside:
_checkToken()を定義したままにします。
|
|
mshim03
reviewed
Jan 29, 2025
web/src/components/PTeamLabel.jsx
Outdated
| @@ -16,7 +16,8 @@ export function PTeamLabel(props) { | |||
|
|
|||
| const [pteamSettingsModalOpen, setPTeamSettingsModalOpen] = useState(false); | |||
|
|
|||
| const skip = useSkipUntilAuthTokenIsReady(); | |||
| const skip = !useSelector((state) => state.auth.authUserIsReady); | |||
There was a problem hiding this comment.
!useSelector((state) => state.auth.authUserIsReady); がコードの中に散らばってますが、元も useSkipUntilAuthTokenisReady のように独自フックにロジックを押し込めた方がいいかもしれません
web/src/pages/App/AppPage.jsx
Outdated
| _checkToken(); | ||
| }, [cookies, dispatch, location, navigate, skip, tryLogin]); | ||
| }); | ||
| }, [location, dispatch, navigate, tryLogin]); |
|
@mshim03
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
経緯・意図・意思決定
auth.currentUser?.getIdToken(true)への変更auth.currentUser?.getIdToken(true)から取得したアクセストークンを使用するように変更しました