-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topic/delete cookie and use getIdToken #568
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7daff1e
topic/delete cookie and use getIdToken
TsurutaYoshiki 4eb970c
delete cookie
TsurutaYoshiki 35358f8
delet useSkipUntilAuthTokenIsReady
TsurutaYoshiki ea59e2b
delete auth slice
TsurutaYoshiki 66fe3f8
Replace with getIdToken
TsurutaYoshiki 69a20fb
delete comment out
TsurutaYoshiki 96d4861
add tryLogin
TsurutaYoshiki 2ab4eef
add skip
TsurutaYoshiki e68e256
Merge branch 'main' into topic/delete-cookie-and-use-getIdToken
TsurutaYoshiki 5ef93c4
Merge branch 'main' into topic/delete-cookie-and-use-getIdToken
TsurutaYoshiki 6e8c4e1
Merge branch 'main' into topic/delete-cookie-and-use-getIdToken
dejima-shikou 3893803
change reference Firebase
dejima-shikou a7abfdb
delete cookie
TsurutaYoshiki fa2772d
delete useSkipUntilAuthUserIsReady
TsurutaYoshiki 9d4872e
add onAuthStateChanged
TsurutaYoshiki ed82362
add authUserIsReady in redux store
TsurutaYoshiki af50ee6
fix formtat
TsurutaYoshiki 8755229
delete tryLogin
TsurutaYoshiki 5218f80
add useSkipUntilAuthUserIsReady
TsurutaYoshiki a684189
add signOut
TsurutaYoshiki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
import { useSelector } from "react-redux"; | ||
|
||
export function useSkipUntilAuthTokenIsReady() { | ||
const authToken = useSelector((state) => state.auth.token); | ||
const skip = authToken === undefined; | ||
return skip; | ||
export function useSkipUntilAuthUserIsReady() { | ||
return !useSelector((state) => state.auth.authUserIsReady); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tryLogin()して、エラーならloginページにnavigate、
の処理は消してはいけないと思います。