chore(tsc): allow entry point of type library #695
+109
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow importing all types from the package with :
```json
{
"compilerOptions": {
"types": ["@numerique-gouv/moncomptepro/src/types"]
}
}
```
douglasduteil
force-pushed
the
douglasduteil/chore-tsc-allow-entry-point-of-type-library
branch
from
0b98c26
to
36ff2e4
Compare
rdubigny
approved these changes
Sep 17, 2024
|
rdubigny
reviewed
Sep 23, 2024
| @@ -22,5 +22,5 @@ jobs: | |||
| node-version-file: package.json | |||
| - run: CYPRESS_INSTALL_BINARY=0 npm ci --include=dev | |||
| - run: npm run test:lint | |||
| - run: npm run test:type-check | |||
| - run: npm exec tsc | |||
There was a problem hiding this comment.
Est ce qu'une compilation implique un type check ? qu'est ce qui est testé en plus ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow importing all types from the package with :
{ "compilerOptions": { "types": ["@numerique-gouv/moncomptepro/src/types"] } }