chore(tsc): allow entry point of type library

.github/workflows/test.yml

@@ -22,5 +22,5 @@ jobs:
           node-version-file: package.json
       - run: CYPRESS_INSTALL_BINARY=0 npm ci --include=dev
       - run: npm run test:lint
-      - run: npm run test:type-check
+      - run: npm exec tsc
       - run: npm run test:unit

package.json

@@ -6,6 +6,20 @@
   "imports": {
     "#cypress/*": "./cypress/*.ts"
   },
+  "exports": {
+    "./connectors/*": {
+      "default": "./build/connectors/*.js"
+    },
+    "./managers/*": {
+      "default": "./build/managers/*.js"
+    },
+    "./types": {
+      "default": "./src/types/index.d.ts"
+    },
+    ".": {
+      "default": "./src/index.ts"
+    }
+  },
   "main": "src/index.js",
   "scripts": {
     "build": "run-s build:**",
@@ -52,6 +66,7 @@
     "@types/ejs": "^3.1.5",
     "@types/express": "^4.17.21",
     "@types/express-session": "^1.18.0",
+    "@types/lodash-es": "^4.17.12",
     "@types/morgan": "^1.9.9",
     "@zootools/email-spell-checker": "^1.12.0",
     "await-to-js": "^3.0.0",
@@ -99,7 +114,6 @@
     "@types/chai-as-promised": "^7.1.8",
     "@types/http-errors": "^2.0.4",
     "@types/lodash": "^4.17.0",
-    "@types/lodash-es": "^4.17.12",
     "@types/mocha": "^10.0.7",
     "@types/node": "^22.1.0",
     "@types/oidc-provider": "^8.5.2",

src/controllers/api.ts

@@ -10,7 +10,7 @@ import notificationMessages from "../config/notification-messages";
 import { getOrganizationInfo } from "../connectors/api-sirene";
 import { sendModerationProcessedEmail } from "../managers/moderation";
 import { forceJoinOrganization } from "../managers/organization/join";
-import { markDomainAsVerified } from "../managers/organization/main";
+import { markDomainAsVerified } from "../managers/organization/markDomainAsVerified";
 import { getUserOrganizationLink } from "../repositories/organization/getters";
 import {
   idSchema,

src/managers/organization/join.ts

@@ -51,7 +51,8 @@ import {
 } from "../../services/organization";
 import { isEmailValid } from "../../services/security";
 import { unableToAutoJoinOrganizationMd } from "../../views/mails/unable-to-auto-join-organization";
-import { getOrganizationsByUserId, markDomainAsVerified } from "./main";
+import { getOrganizationsByUserId } from "./main";
+import { markDomainAsVerified } from "./markDomainAsVerified";
 
 export const doSuggestOrganizations = async ({
   user_id,

src/managers/organization/main.ts

@@ -1,21 +1,12 @@
-import { isEmpty, some } from "lodash-es";
+import { isEmpty } from "lodash-es";
 import { NotFoundError } from "../../config/errors";
-import {
-  addDomain,
-  findEmailDomainsByOrganizationId,
-} from "../../repositories/email-domain";
 import {
   findByUserId,
   findById as findOrganizationById,
   findPendingByUserId,
-  getUsers,
 } from "../../repositories/organization/getters";
-import {
-  deleteUserOrganization,
-  updateUserOrganizationLink,
-} from "../../repositories/organization/setters";
+import { deleteUserOrganization } from "../../repositories/organization/setters";
 import { setSelectedOrganizationId } from "../../repositories/redis/selected-organization";
-import { getEmailDomain } from "../../services/email";
 
 export const getOrganizationsByUserId = findByUserId;
 export const getOrganizationById = findOrganizationById;
@@ -50,56 +41,6 @@ export const quitOrganization = async ({
 
   return true;
 };
-export const markDomainAsVerified = async ({
-  organization_id,
-  domain,
-  domain_verification_type,
-}: {
-  organization_id: number;
-  domain: string;
-  domain_verification_type: EmailDomain["verification_type"];
-}) => {
-  const organization = await findOrganizationById(organization_id);
-  if (isEmpty(organization)) {
-    throw new NotFoundError();
-  }
-  const emailDomains = await findEmailDomainsByOrganizationId(organization_id);
-
-  if (
-    !some(emailDomains, { domain, verification_type: domain_verification_type })
-  ) {
-    await addDomain({
-      organization_id,
-      domain,
-      verification_type: domain_verification_type,
-    });
-  }
-
-  const usersInOrganization = await getUsers(organization_id);
-
-  await Promise.all(
-    usersInOrganization.map(
-      ({ id, email, verification_type: link_verification_type }) => {
-        const userDomain = getEmailDomain(email);
-        if (
-          userDomain === domain &&
-          [
-            null,
-            "no_verification_means_available",
-            "no_verification_means_for_entreprise_unipersonnelle",
-          ].includes(link_verification_type)
-        ) {
-          return updateUserOrganizationLink(organization_id, id, {
-            verification_type: "domain",
-          });
-        }
-
-        return null;
-      },
-    ),
-  );
-};
-
 export const selectOrganization = async ({
   user_id,
   organization_id,

src/managers/organization/markDomainAsVerified.ts

@@ -0,0 +1,61 @@
+import { isEmpty, some } from "lodash-es";
+import { NotFoundError } from "../../config/errors";
+import {
+  addDomain,
+  findEmailDomainsByOrganizationId,
+} from "../../repositories/email-domain";
+import { findById, getUsers } from "../../repositories/organization/getters";
+import { updateUserOrganizationLink } from "../../repositories/organization/setters";
+import { getEmailDomain } from "../../services/email";
+
+//
+
+export const markDomainAsVerified = async ({
+  organization_id,
+  domain,
+  domain_verification_type,
+}: {
+  organization_id: number;
+  domain: string;
+  domain_verification_type: EmailDomain["verification_type"];
+}) => {
+  const organization = await findById(organization_id);
+  if (isEmpty(organization)) {
+    throw new NotFoundError();
+  }
+  const emailDomains = await findEmailDomainsByOrganizationId(organization_id);
+
+  if (
+    !some(emailDomains, { domain, verification_type: domain_verification_type })
+  ) {
+    await addDomain({
+      organization_id,
+      domain,
+      verification_type: domain_verification_type,
+    });
+  }
+
+  const usersInOrganization = await getUsers(organization_id);
+
+  await Promise.all(
+    usersInOrganization.map(
+      ({ id, email, verification_type: link_verification_type }) => {
+        const userDomain = getEmailDomain(email);
+        if (
+          userDomain === domain &&
+          [
+            null,
+            "no_verification_means_available",
+            "no_verification_means_for_entreprise_unipersonnelle",
+          ].includes(link_verification_type)
+        ) {
+          return updateUserOrganizationLink(organization_id, id, {
+            verification_type: "domain",
+          });
+        }
+
+        return null;
+      },
+    ),
+  );
+};

src/managers/webauthn.ts

@@ -8,6 +8,8 @@ import {
 } from "@simplewebauthn/server";
 import type {
   AuthenticationResponseJSON,
+  PublicKeyCredentialCreationOptionsJSON,
+  PublicKeyCredentialRequestOptionsJSON,
   RegistrationResponseJSON,
 } from "@simplewebauthn/types";
 import { isEmpty } from "lodash-es";
@@ -115,7 +117,10 @@ export const deleteUserAuthenticator = async (
   return true;
 };
 
-export const getRegistrationOptions = async (email: string) => {
+export const getRegistrationOptions: (email: string) => Promise<{
+  updatedUser: User;
+  registrationOptions: PublicKeyCredentialCreationOptionsJSON;
+}> = async (email) => {
   const user = await findUserByEmail(email);
 
   if (isEmpty(user)) {
@@ -232,10 +237,13 @@ export const verifyRegistration = async ({
   return { userVerified: user_verified, user: await enableForce2fa(user.id) };
 };
 
-export const getAuthenticationOptions = async (
+export const getAuthenticationOptions: (
   email: string | undefined,
   isSecondFactorAuthentication: boolean,
-) => {
+) => Promise<{
+  updatedUser: User;
+  authenticationOptions: PublicKeyCredentialRequestOptionsJSON;
+}> = async (email, isSecondFactorAuthentication) => {
   if (!email) {
     throw new NotFoundError();
   }

src/types/index.d.ts

@@ -1,3 +1,14 @@
+/// <reference path="./authenticator.d.ts" />
+/// <reference path="./connection.d.ts" />
+/// <reference path="./email-domain.d.ts" />
 /// <reference path="./express-session.d.ts" />
-/// <reference path="./user.d.ts" />
+/// <reference path="./is-disposable-email-domain.d.ts" />
+/// <reference path="./moderation.d.ts" />
+/// <reference path="./oidc-client.d.ts" />
+/// <reference path="./oidc-provider.d.ts" />
+/// <reference path="./organization-info.d.ts" />
+/// <reference path="./organization.d.ts" />
 /// <reference path="./request.d.ts" />
+/// <reference path="./tld-extract.d.ts" />
+/// <reference path="./user-organization-link.d.ts" />
+/// <reference path="./user.d.ts" />

tsconfig.json

@@ -2,6 +2,7 @@
   "compilerOptions": {
     "allowJs": true,
     "allowSyntheticDefaultImports": true,
+    "declaration": true,
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "module": "Preserve",