-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(frontend) team description #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
4 times, most recently
from
February 12, 2024 16:09
157f251
to
ba97b77
Compare
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
from
February 12, 2024 16:10
ba97b77
to
418aaa2
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
4 times, most recently
from
February 13, 2024 10:15
8c34edf
to
45083d1
Compare
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
from
February 13, 2024 11:58
418aaa2
to
c329e40
Compare
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
3 times, most recently
from
February 13, 2024 12:37
3cc8533
to
91a89f9
Compare
AntoLC
changed the base branch from
main
to
feature/frontend/basic-page-team
February 13, 2024 12:52
AntoLC
force-pushed
the
feature/frontend/basic-page-team
branch
3 times, most recently
from
February 19, 2024 14:16
08ce5a6
to
7e49a25
Compare
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
2 times, most recently
from
February 19, 2024 14:51
f0d8f25
to
ddcdfef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/frontend/apps/desk/src/features/teams/components/TeamInfo.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/components/TeamInfo.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/components/TeamInfo.tsx
Outdated
Show resolved
Hide resolved
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
from
February 21, 2024 09:05
ddcdfef
to
01594cc
Compare
lebaudantoine
approved these changes
Feb 22, 2024
The text color from the mockup is not blue but a dark grey. This commit changes the base color of the Text component to match the mockup.
Add the team info component to the team page. This component shows some informations about the team: - name - amount of members - date created - date updated
The parser was not adding the dot in the key to the json file sent to crowdin. Some translations were not being translated correctly.
AntoLC
force-pushed
the
feature/frontend/team-desc
branch
from
February 22, 2024 12:57
64aa8ad
to
2fb258e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create the box team description.
Proposal
Demo
scrnli_2_13_2024_1-51-54.PM.webm