Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(frontend) team description #49

Merged
merged 3 commits into from
Feb 22, 2024
Merged

✨(frontend) team description #49

merged 3 commits into from
Feb 22, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Feb 12, 2024

Purpose

Create the box team description.

Proposal

  • Integrate the design from the mockup

Demo

scrnli_2_13_2024_1-51-54.PM.webm

@AntoLC AntoLC self-assigned this Feb 12, 2024
@AntoLC AntoLC force-pushed the feature/frontend/team-desc branch 4 times, most recently from 157f251 to ba97b77 Compare February 12, 2024 16:09
@AntoLC AntoLC marked this pull request as ready for review February 12, 2024 16:09
@AntoLC AntoLC changed the base branch from main to feature/frontend/create-team February 12, 2024 16:09
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch 4 times, most recently from 8c34edf to 45083d1 Compare February 13, 2024 10:15
@AntoLC AntoLC removed the request for review from lebaudantoine February 13, 2024 11:05
@AntoLC AntoLC changed the base branch from feature/frontend/create-team to main February 13, 2024 11:59
@AntoLC AntoLC force-pushed the feature/frontend/team-desc branch 3 times, most recently from 3cc8533 to 91a89f9 Compare February 13, 2024 12:37
@AntoLC AntoLC changed the base branch from main to feature/frontend/basic-page-team February 13, 2024 12:52
@AntoLC AntoLC force-pushed the feature/frontend/basic-page-team branch 3 times, most recently from 08ce5a6 to 7e49a25 Compare February 19, 2024 14:16
Base automatically changed from feature/frontend/basic-page-team to main February 19, 2024 14:22
@AntoLC AntoLC force-pushed the feature/frontend/team-desc branch 2 times, most recently from f0d8f25 to ddcdfef Compare February 19, 2024 14:51
Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The text color from the mockup is not blue but
a dark grey. This commit changes the base color of
the Text component to match the mockup.
Add the team info component to the team page.
This component shows some informations about the team:
  - name
  - amount of members
  - date created
  - date updated
The parser was not adding the dot in the key to the
json file sent to crowdin. Some translations were
not being translated correctly.
@AntoLC AntoLC merged commit 4bd8095 into main Feb 22, 2024
12 checks passed
@AntoLC AntoLC deleted the feature/frontend/team-desc branch February 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants