[W13-1] InsuRen #91

zioul123 · 2018-10-02T03:34:39Z

@A19Sean @AyushChatto @denzelchung @chantca95

asiddharth

Good job! Some minor UG and DG comments

asiddharth · 2018-10-02T08:45:26Z

docs/UserGuide.adoc

@@ -50,19 +50,25 @@ e.g. typing *`help`* and pressing kbd:[Enter] will open the help window.
 * Items in square brackets are optional e.g `n/NAME [t/TAG]` can be used as `n/John Doe t/friend` or as `n/John Doe`.
 * Items with `…` after them can be used multiple times including zero times e.g. `[t/TAG]...` can be used as `{nbsp}` (i.e. 0 times), `t/friend`, `t/friend t/family` etc.
 * Parameters can be in any order e.g. if the command specifies `n/NAME p/PHONE_NUMBER`, `p/PHONE_NUMBER n/NAME` is also acceptable.
+* All commands have a shorthand version for easy access. Simply replace the command word with the shorthand. All other syntax is identical.


This file still reads as a user guide for AB4

src/main/java/seedu/address/logic/commands/EditCommand.java

asiddharth · 2018-10-02T08:48:35Z

src/main/java/seedu/address/logic/commands/ImportCommand.java

+import seedu.address.model.Model;
+import seedu.address.model.person.Person;
+/**
+ * Adds a list of pre-established Valid persons to the address book.


Good job for the header comment!

asiddharth · 2018-10-02T08:49:08Z

src/main/java/seedu/address/logic/commands/ImportCommand.java

+     */
+    @Override
+    public CommandResult execute(Model model, CommandHistory history) {
+


Extra blank line. Use blank lines sparingly. It's good to have blank lines to separate logical code blocks, but too many blank lines will increase the height of the code, which increases the amount of scrolling.

asiddharth · 2018-10-02T08:50:19Z

src/main/java/seedu/address/logic/commands/ImportCommand.java

@@ -0,0 +1,92 @@
+//@@author chantca95


Maybe better to include this as a part of the class header comment

asiddharth · 2018-10-02T08:50:36Z

src/main/java/seedu/address/logic/commands/ScheduleCommand.java

+
+        return new Person(name, phone, email, address, tags, meeting);
+    }
+


Extra blank line. Use blank lines sparingly. It's good to have blank lines to separate logical code blocks, but too many blank lines will increase the height of the code, which increases the amount of scrolling.

asiddharth · 2018-10-02T08:52:04Z

README.adoc

 * <<AboutUs#, About Us>>
 * <<ContactUs#, Contact Us>>

 == Acknowledgements

 * Some parts of this sample application were inspired by the excellent http://code.makery.ch/library/javafx-8-tutorial/[Java FX tutorial] by
 _Marco Jakob_.
+* This project was evolved from the "AddressBook-Level4" project created by SE-EDU initiative at https://github.com/se-edu/


Good job acknowledging AB4!

asiddharth · 2018-10-02T08:53:51Z

docs/DeveloperGuide.adoc

+
+Use case resumes at step 1.
+
+


Maybe good to add some NFRs specific to the product.

Same comment again.

asiddharth

Good job overall team.
Here are a few comments in addition to the ones pointed out.

Please change the product description.
Upfdate the Contact Us page with the appropriate links/emails.
Update the introduction in UG to suit your product
May want to rename your jar and link it correctly.
Please add some coming in 2.0 features.
Test coverage seems good. Try to add come more to get coverage > 90%

asiddharth · 2018-10-06T16:34:03Z

README.adoc

-https://www.codacy.com/app/damith/addressbook-level4?utm_source=github.com&utm_medium=referral&utm_content=se-edu/addressbook-level4&utm_campaign=Badge_Grade[image:https://api.codacy.com/project/badge/Grade/fc0b7775cf7f4fdeaf08776f3d8e364a[Codacy Badge]]
+https://travis-ci.org/CS2103-AY1819S1-W13-1/main[image:https://travis-ci.org/CS2103-AY1819S1-W13-1/main.svg?branch=master[Build Status]]
+https://ci.appveyor.com/project/denzelchung/main-1gn9v/branch/master[image:https://ci.appveyor.com/api/projects/status/0cw1hdcgcqu31k9l/branch/master?svg=true[Build status]]
+https://coveralls.io/github/CS2103-AY1819S1-W13-1/main?branch=master[image:https://coveralls.io/repos/github/CS2103-AY1819S1-W13-1/main/badge.svg?branch=master[Coverage Status]]
 https://gitter.im/se-edu/Lobby[image:https://badges.gitter.im/se-edu/Lobby.svg[Gitter chat]]


Can remove/change this link as it points to AB4

asiddharth · 2018-10-07T02:48:54Z

README.adoc

 * <<AboutUs#, About Us>>
 * <<ContactUs#, Contact Us>>

 == Acknowledgements

 * Some parts of this sample application were inspired by the excellent http://code.makery.ch/library/javafx-8-tutorial/[Java FX tutorial] by
 _Marco Jakob_.
+* This project was evolved from the "AddressBook-Level4" project created by SE-EDU initiative at https://github.com/se-edu/
 * Libraries used: https://github.com/TestFX/TestFX[TextFX], https://bitbucket.org/controlsfx/controlsfx/[ControlsFX], https://github.com/FasterXML/jackson[Jackson], https://github.com/google/guava[Guava], https://github.com/junit-team/junit5[JUnit5]


Good job on :

Adding UI Mockup
Modifying home page for the product.
Acknowledging AB4
Adding correct links for travis.

asiddharth · 2018-10-07T02:49:41Z

docs/AboutUs.adoc

-{empty}[http://www.comp.nus.edu.sg/~damithch[homepage]] [https://github.com/damithc[github]] [<<johndoe#, portfolio>>]
+=== Auyok Sean
+image::a19sean.png[width="150", align="left"]
+{empty}[https://github.com/A19Sean[github]]


May be helpful to add the portfolio for each team member. Will be useful to keep everything updated as you progress with the project.

https://nus-cs2103-ay1819s1.github.io/cs2103-website/admin/project-deliverables.html#deliverable-project-portfolio-page-ppp

asiddharth · 2018-10-07T02:57:34Z

docs/UserGuide.adoc

@@ -94,11 +106,42 @@ Edits the phone number and email address of the 1st person to be `91234567` and
 * `edit 2 n/Betsy Crower t/` +
 Edits the name of the 2nd person to be `Betsy Crower` and clears all existing tags.

+==== Editing by name
+


Would be good to add some examples with the shorthand. Same comment applies to all commands.

asiddharth · 2018-10-07T02:59:28Z

docs/UserGuide.adoc

+* `import`
+* A file browser will pop up as shown below:
+
+image::import.png[width="790"]


Good job here!

asiddharth · 2018-10-07T03:02:46Z

src/main/java/seedu/address/logic/commands/ImportCommand.java

+package seedu.address.logic.commands;
+
+import static java.util.Objects.requireNonNull;
+


Extra blank line. Use blank lines sparingly. It's good to have blank lines to separate logical code blocks, but too many blank lines will increase the height of the code, which increases the amount of scrolling.

asiddharth · 2018-10-07T03:07:52Z

docs/DeveloperGuide.adoc

+
+Use case resumes at step 1.
+
+


Same comment again.

asiddharth · 2018-10-07T03:11:33Z

docs/DeveloperGuide.adoc

+
+[none]
+** 1a1. AddressBook shows an error message.
+Step 1 is repeated until the data entered are correct.


Can modify this to

Use case resumes at Step 1

asiddharth · 2018-10-07T03:21:56Z

docs/DeveloperGuide.adoc

+*MSS*
+
+1. User inputs the customers’ meeting times in their address book entries.
+2. User searches for meetings with clients by time, and AddressBook returns the client details if there is a meeting scheduled at that time.


Each step should alternate between the user and InsuRen as the actor.

asiddharth · 2018-10-07T03:22:11Z

docs/DeveloperGuide.adoc

+*MSS*
+
+1. User requests to add client, specifying the compulsory field (name) and non-compulsory fields (address, email, phone number, and tags).
+2. AddressBook stores the new client, and displays a confirmation message.


Should this not be InsuRen?

asiddharth

Hi team!
Here are some suggestions regarding your project

Make sure the build passes before the testing session.

Some DG related comments :
Your DG looks very similar to that of the parent repository. You might want to consider doing some of the following things.
1.

As your project is a morph of AB4, it would be better to remove the links to AB1, AB2, AB3 and AB4 in your autopublished website.

2.Good job adding feature implementation details and the activity diagrams for the features. Would be nice to add additional sequence, class diagrams as well for other features if applicable.
3. Many references to AB4. Could help to remove references related to AB4 not relevant to your project application.
4. Add more NFRs?

v1.3 Search by meeting

* master: Fix formatting issues Change meetings alias add diagrams for import and export command safety store Fix formatting issues Fix formatting issues Check for meeting prefix Update test cases Add search by meeting command WIP WIP # Conflicts: # src/main/java/seedu/address/logic/parser/AddressBookParser.java

Portfolio update

* tag-delete-tests: Update expectedExport.csv to match TypicalPersons.java Implement TagCommandParserTest Edit TypicalPersons to have separate persons to test tag functionality Revert typicalPersonsAddressBook.xml to original addressbook xml file Add author tag Add TagDeleteCommandTest Update TagCommandTest Update typicalPersonsAddressBook to a functioning contact list

v1.3 Update documentation

… tags

resize and merge screenshot

…ds in dev guide.

Change the "do not use edit or delete" in tags to a recommendation.

…into 1.4_resize_screenshots

Update dev guide

Fix documentation issues

1.4 resize screenshots

Fix Typo in Portfolio

* master: typo fix and make import sample screenshots bigger 2 typo fix and make import sample screenshots bigger Fix github links. Update user-stories, use-case, nfrs and manual testing for tag commands in dev guide. Change conditions to lower case. Change the "do not use edit or delete" in tags to a recommendation.

Update ppp.

* master: Update ppp. Fix Typo in Portfolio

Change image sizes.

* master: Change image sizes.

A19sean PPP

Update Version Number

Update ppp

zioul123 mentioned this pull request Oct 2, 2018

PR to AB level 4 CS2103-AY1819S1-W13-1/main#26

Closed

nus-se-pr-bot added tutorial.W13 team.1 labels Oct 2, 2018

nus-se-pr-bot assigned asiddharth Oct 2, 2018

nus-se-pr-bot requested a review from asiddharth October 2, 2018 03:36

asiddharth reviewed Oct 2, 2018

View reviewed changes

asiddharth added the Mid-v1.1-Reviewed label Oct 2, 2018

asiddharth reviewed Oct 7, 2018

View reviewed changes

asiddharth added the v1.1-Reviewed label Oct 7, 2018

asiddharth reviewed Oct 21, 2018

View reviewed changes

asiddharth added the v1.2-Reviewed label Oct 21, 2018

AyushChatto and others added 19 commits October 29, 2018 22:19

Fix formatting issues

0f61c2f

Merge pull request #85 from AyushChatto/searchByMeeting

adfbd90

v1.3 Search by meeting

Update add picture feature's documentation.

594f65a

Add more information to developer guide.

247e58e

Update portfolio.

d42d2cd

Add non-functional requirements.

15f159b

Add author tag

5a2499c

Revert typicalPersonsAddressBook.xml to original addressbook xml file

65435c5

Edit TypicalPersons to have separate persons to test tag functionality

e068fe8

Implement TagCommandParserTest

07e9e25

Merge pull request #94 from denzelchung/portfolio-update

da1d6dc

Portfolio update

Update expectedExport.csv to match TypicalPersons.java

b268ee2

Merge branch 'master' into documentation-changes-picture

c4f27b4

Add tag edit feature

c1aa807

Merge pull request #91 from AyushChatto/updateDocsMeetingsCommand

3baac26

v1.3 Update documentation

Edit TagCommandParser to remove "delete" and "edit" from TagCommand's…

f60b0a6

… tags

Add comments to TagCommandTest and TagDeleteCommandTest

a513b88

zioul123 and others added 30 commits November 12, 2018 21:40

Change conditions to lower case.

03a545e

Merge pull request #179 from chantca95/1.4_resize_screenshots

8c8048a

resize and merge screenshot

Update user-stories, use-case, nfrs and manual testing for tag comman…

d7f54ca

…ds in dev guide.

Fix github links.

8947dad

Merge master into update-dev-guide

e728371

Merge pull request #181 from zioul123/edit-delete-tags

6819c8a

Change the "do not use edit or delete" in tags to a recommendation.

typo fix and make import sample screenshots bigger

cbda3a9

Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/main …

416fc22

…into 1.4_resize_screenshots

typo fix and make import sample screenshots bigger 2

d08a887

Fix Typo in Portfolio

c41cc1a

Update ppp.

57f5aec

Merge pull request #183 from A19Sean/update-dev-guide

6d50e41

Update dev guide

Merge pull request #182 from zioul123/ModifyActivityDiagrams

74c99cb

Fix documentation issues

Update PPP

9746ae7

Merge pull request #184 from chantca95/1.4_resize_screenshots

f9645fb

1.4 resize screenshots

Merge pull request #185 from AyushChatto/fixPortfolioTypo

b6eaed5

Fix Typo in Portfolio

Merge pull request #186 from zioul123/ppp-update

fb0dda1

Update ppp.

Merge branch 'master' into a19sean-ppp

1e0ebcf

* master: Update ppp. Fix Typo in Portfolio

Fix typo

ffde06e

Change image sizes.

3946f53

Change PPP to use real links

947750d

Merge pull request #188 from zioul123/ppp-update

caa8597

Change image sizes.

Merge branch 'master' into a19sean-ppp

3664bf8

* master: Change image sizes.

Merge pull request #187 from A19Sean/a19sean-ppp

daeccc9

A19sean PPP

Remove whitespace

0a43536

Update Version Number

068e150

Merge pull request #189 from AyushChatto/deleteWhitespace

9005525

Update Version Number

Update ppp

ea49d45

Merge pull request #190 from A19Sean/edit-a19sean-ppp

49ac2e2

Update ppp

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[W13-1] InsuRen #91

[W13-1] InsuRen #91

zioul123 commented Oct 2, 2018

asiddharth left a comment

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 2, 2018

asiddharth Oct 7, 2018

asiddharth left a comment

asiddharth Oct 6, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth Oct 7, 2018

asiddharth left a comment


		return new Person(name, phone, email, address, tags, meeting);
		}

		package seedu.address.logic.commands;

		import static java.util.Objects.requireNonNull;

[W13-1] InsuRen #91

Are you sure you want to change the base?

[W13-1] InsuRen #91

Conversation

zioul123 commented Oct 2, 2018

asiddharth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asiddharth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asiddharth left a comment

Choose a reason for hiding this comment