forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W13-1] InsuRen #91
Open
zioul123
wants to merge
652
commits into
nus-cs2103-AY1819S1:master
Choose a base branch
from
CS2103-AY1819S1-W13-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[W13-1] InsuRen #91
Changes from all commits
Commits
Show all changes
652 commits
Select commit
Hold shift + click to select a range
0f61c2f
Fix formatting issues
adfbd90
Merge pull request #85 from AyushChatto/searchByMeeting
denzelchung 594f65a
Update add picture feature's documentation.
denzelchung 247e58e
Add more information to developer guide.
denzelchung d42d2cd
Update portfolio.
denzelchung 15f159b
Add non-functional requirements.
denzelchung 5a2499c
Add author tag
A19Sean 65435c5
Revert typicalPersonsAddressBook.xml to original addressbook xml file
A19Sean e068fe8
Edit TypicalPersons to have separate persons to test tag functionality
A19Sean 07e9e25
Implement TagCommandParserTest
A19Sean b49eca9
Merge branch 'master' into tag-delete-tests
A19Sean da1d6dc
Merge pull request #94 from denzelchung/portfolio-update
chantca95 b268ee2
Update expectedExport.csv to match TypicalPersons.java
A19Sean c4f27b4
Merge branch 'master' into documentation-changes-picture
denzelchung c1aa807
Add tag edit feature
A19Sean bb5fff6
Merge branch 'tag-delete-tests' into tag-edit-feature
A19Sean 3baac26
Merge pull request #91 from AyushChatto/updateDocsMeetingsCommand
A19Sean f60b0a6
Edit TagCommandParser to remove "delete" and "edit" from TagCommand's…
A19Sean a513b88
Add comments to TagCommandTest and TagDeleteCommandTest
A19Sean 5d301b8
Implement tests for tag edit functionality
A19Sean 4327098
Merge branch 'master' into documentation-changes-picture
denzelchung c19da86
Merge pull request #93 from denzelchung/documentation-changes-picture
chantca95 5bca1cd
Fixed formatting and redundant information for DeveloperGuide.
denzelchung ea5740a
UserGuide.adoc: Add deleting by name feature to UserGuide.
zioul123 c35bfa2
Add "by name" commands to Command Summary.
zioul123 8ae22e0
DeveloperGuide.adoc: Pull out general "ByNameCommands" portion.
zioul123 377dfff
DeveloperGuide.adoc: Writeup the DeleteByNameCommand implementation.
zioul123 10c704f
DeveloperGuide.adoc: Modify sentence structure.
zioul123 9029bf3
DeveloperGuide.adoc: Clarify a statement in the guide.
zioul123 0c95e9c
DeveloperGuide.adoc: Update markdown formatting.
zioul123 c63d198
Merge pull request #96 from denzelchung/documentation-fix
zioul123 60b0bf0
Merge pull request #89 from A19Sean/tag-delete-tests
zioul123 790bc10
Merge branch 'master' into tag-edit-feature
A19Sean 9181778
Edit class description for TagEditCommandTest
A19Sean 5505343
Merge pull request #97 from zioul123/v1.3-Documentation-Additions
A19Sean 906d7c4
updatedUserGuide
814987c
Merge pull request #98 from A19Sean/tag-edit-feature
chantca95 d2d4fe5
Merge pull request #100 from AyushChatto/updateUserGuide
chantca95 46c8f88
Update UserGuide.adoc
A19Sean 93efe24
Update DeveloperGuide.adoc for tag feature
A19Sean 840ef23
Add to DeveloperGuide that TagCommand can be undone or redone
A19Sean bca6e27
Style fixes
A19Sean 5f21c5b
Changes according to TA's comments
A19Sean 61fc842
Merge pull request #103 from A19Sean/edits-according-to-ta
AyushChatto 72676f6
Reduce size of images for tag feature in DeveloperGuide
A19Sean 77ff283
Merge pull request #102 from A19Sean/tag-feature-documentation
AyushChatto b940b61
Updated version number in MainApp
A19Sean 35f9549
Merge pull request #104 from A19Sean/release-v1.3
AyushChatto f282143
Retain pictures
f1a123a
Merge branch 'master' into retainPictureAfterMeeting
8e39448
Fix formatting issues
99feb08
Use new constructor instead of setter
3ac9300
Change phrasing and fix formatting.
zioul123 78b95a7
Add to UserGuide that Person cannot have "edit" and "delete" tags.
A19Sean 3455806
Remove unnecessary lines.
zioul123 69d3a5d
Fix edit command
6e88047
Change meetings shorthand
6b616f5
Change the title of the app from Address App to InsuRen.
zioul123 9f9b26c
update user docs to better instruct users
chantca95 1c27e13
Fix failing test.
zioul123 4802496
Merge pull request #106 from AyushChatto/retainPictureAfterMeeting
zioul123 e571820
Merge pull request #110 from AyushChatto/updateGuidesv1.3
zioul123 2f96ee6
Merge pull request #113 from chantca95/doc_updates_1.3
zioul123 7d0f8e6
Fix file path.
denzelchung ef02b56
fix export command
chantca95 25565ad
fix export command 2
chantca95 954b2aa
Merge pull request #114 from chantca95/export_command_fixes_1.3
zioul123 482b177
fix export command - catch existing csv file name
chantca95 560e4a8
Merge pull request #112 from zioul123/Change-title-of-app
AyushChatto 01c3b93
Merge pull request #107 from zioul123/Small-changes-to-dev-guide
AyushChatto 4143d65
checkStyle
chantca95 5bc3a29
Update user guide schedule
5fce935
Merge pull request #115 from chantca95/export_command_fixes_1.3
zioul123 74c865f
Merge pull request #116 from AyushChatto/appendScheduleUserGuideEntry
zioul123 5bafed3
change export command to put blankspace for no meeting
chantca95 80c504a
Fix path validation for Windows and Mac OS.
denzelchung 62c53ff
Merge pull request #117 from chantca95/exportCommandBugFix_1.3
zioul123 0680fe0
Change "cannot" to "should not" for UserGuide
A19Sean c16c6b8
Merge branch 'master' into fix-tag-documentation
A19Sean 1d02cb1
fix exportCommand test file
chantca95 6086b6e
Merge pull request #108 from A19Sean/fix-tag-documentation
AyushChatto a66c9cf
Add author tags in TypicalPersons.java
A19Sean c9526b8
Merge branch 'master' into add-author-tag
A19Sean 014a916
fix exportcommandtest 1
chantca95 f4242a8
Add handle for default picture case.
denzelchung 7584d59
Merge pull request #120 from A19Sean/add-author-tag
AyushChatto e3a5f0a
Merge pull request #118 from denzelchung/pic-path-fix
zioul123 891618b
exportcommandtest bug fix
chantca95 fc5ecab
update version number
A19Sean f0567b9
disable exportcommandtest
chantca95 090d1f9
disable exportcommandtest 2
chantca95 2007e7d
Merge pull request #122 from A19Sean/update-main-app-v1.3.1
AyushChatto 37dce61
Merge pull request #119 from chantca95/exportcommand_test_1.3
A19Sean b203e46
Add reposense config file
A19Sean 85b4155
Add newline at EOF
A19Sean ee1d79c
Merge pull request #123 from A19Sean/add-reposense-config
zioul123 10131d9
Check meeting time for validity
1574646
Fix formatting issues
6a6503d
Merge pull request #124 from AyushChatto/checkMeetingTimeForValidity
A19Sean 37dfb1f
Update user guide for clarity.
denzelchung 57d2f23
Fix bug where meeting get removed.
denzelchung c903f5c
Fix layout formatting when a long name is input.
denzelchung 7c2b01c
Prevent the dummy page from appearing when a person card is clicked on.
zioul123 cbfe069
Remove the dummy search page.
zioul123 f1e24bf
Fix tests.
zioul123 e170745
Remove unused import statement.
zioul123 1d7ba2e
Merge pull request #143 from denzelchung/ui-fix
zioul123 bdf5999
Merge pull request #142 from denzelchung/pic-meeting-fix
zioul123 b5a0c90
Merge pull request #141 from denzelchung/user-guide-pic-update
zioul123 bb103fe
Make date validation stricter
709346e
Make time validation stricter
faad4e0
UserGuide.adoc: Make it clear that fields are optional.
zioul123 df56ec0
Update the UserGuide and portfolio.
zioul123 7c10ed3
Add explanation to the minor enhancement.
zioul123 c957b09
Merge pull request #146 from zioul123/Webpage
denzelchung b8bbef8
Update project portfolio page.
denzelchung ca78f44
Add more non-functional requirements.
denzelchung f4b06c6
Modify name of PPP to be github username, and omit a section.
zioul123 fc2524c
Add RepoSense link to PPP.
zioul123 e6f35d8
Fix the plural form of "salesman" to "salesmen".
zioul123 132d582
Fix Dev Guide Use Case
82dae11
Fix typo
8fffc6b
Merge pull request #155 from AyushChatto/fixDevGuide
zioul123 9ce165d
Merge pull request #147 from AyushChatto/makeDateRequirementsStrict
A19Sean b65ab48
Merge pull request #154 from zioul123/Grammar-change
A19Sean 0b41c9e
Remove irrelevant parts of the DeveloperGuide.
zioul123 dccabd5
Merge pull request #156 from zioul123/Grammar-change
A19Sean 88f7521
Add more documentation for Picture.
denzelchung da73a24
refactor ImportCommandPreparer to ImportCommandParser
chantca95 ee5d010
checkStyle 1
chantca95 fa1ed6f
minor renaming
chantca95 2098154
Merge pull request #158 from chantca95/1.4_refactoring
AyushChatto 5a892b0
edit import and export parser and command tests
chantca95 0fc316c
checkstyle 1
chantca95 b46d1e9
Update mdoel class diagram to indicate optional fields.
zioul123 26770c0
Remove reference to an unused AB4 suggestion.
zioul123 a96ddf5
Modify the format for "Note:".
zioul123 7d1d59e
Add more details for PictureCommand documentation.
denzelchung e12f8c1
Resize images.
denzelchung d1c8c3f
checkstyle 2
chantca95 7370fa1
Make sequence diagram consistent.
denzelchung 972770d
revert
chantca95 dfbf812
add ignore case for exportcommand test
chantca95 72f0899
checkStyle 1
chantca95 e6bb891
Add references to UG and DG.
denzelchung 086b691
Fix formatting issues from v1.3
e59b4fb
refactor
chantca95 3e128ae
Modify the model class diagram to indicate the number of optional fie…
zioul123 684ae93
Merge pull request #151 from denzelchung/ppp-update
chantca95 1594289
Merge pull request #152 from denzelchung/dev-update
chantca95 f33d7d3
Merge pull request #157 from denzelchung/ug-update
chantca95 81ac5fa
Merge pull request #159 from chantca95/1.4_test_updates
zioul123 3a46ff1
Fix activity diagram for meetings
439d466
Merge pull request #161 from AyushChatto/fixv1.3feedback
zioul123 dbb8afd
Add ByNameCommandSequenceDiagram.
zioul123 6818782
Update diagrams to be more general.
zioul123 d4550f5
Update the By Name Command Class Diagram.
zioul123 81a9041
Add ByNameCommandClassDiagram.
zioul123 9a9e3e1
Update ByNameCommandSequenceDiagram.
zioul123 52857ee
Update the by name command sequence diagram.
zioul123 3e3931c
Include the new diagrams in the Developer Guide.
zioul123 237ad49
Add community bug reports to PPP.
zioul123 29628e9
Update PPP and Dev Guide
3ad6716
Update PPP.
zioul123 ca2f773
update portfolio
chantca95 1b79873
Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/mai…
chantca95 4fa18ff
Merge pull request #160 from zioul123/DG-Images
denzelchung 3e093c5
add sequence diagrams for import and export
chantca95 d06ad04
Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/mai…
chantca95 7f8578b
Merge pull request #166 from AyushChatto/updatePPP
zioul123 cfd2303
add sequence diagrams to DG
chantca95 5a73364
Merge pull request #162 from AyushChatto/fixActivityDiagram
zioul123 78c9fbf
Put code tags around Person/person to be `Person`
zioul123 5b95898
Update use cases.
zioul123 2cef0d2
edit docs
chantca95 2a7ec5e
Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/mai…
chantca95 5da0a48
checkStyle1
chantca95 6d68813
Update personal portfolio page.
denzelchung 84ebbd0
Merge pull request #167 from chantca95/1.4_documentation
zioul123 cd4d6f4
Merge branch 'master' into v1.4-Documentation
zioul123 002d9c8
add manual testing instructions
chantca95 0466c24
Merge pull request #168 from denzelchung/ppp-update-2
chantca95 677367f
checkStyle 1
chantca95 6a591af
Update manual testing instructions.
denzelchung f2ba134
Add missing image files situation.
denzelchung 8381acb
add tags to DG
chantca95 dacb7fe
Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/mai…
chantca95 d1fb830
rename ppp
chantca95 6443a5c
Add more test cases.
denzelchung 3cab9e0
Fix formatting.
denzelchung db53e7a
Add new line at end of file.
denzelchung ab9f491
Add tags and small fixes to DG.
zioul123 d820168
Merge pull request #171 from denzelchung/dg-testing-pic
zioul123 4c195b0
Merge branch 'master' into v1.4-Documentation
zioul123 cfe5c2c
Merge branch 'master' into 1.4_manual_testing
chantca95 bf07f35
Add shorthand examples for add, delete and edit commands.
zioul123 c4c59bd
Add tagcommand sequence diagram to developer guide
A19Sean a9a05b6
Merge branch 'master' into tagcommand-sequence-diagram
A19Sean 8d1e515
Add manual test cases.
zioul123 1e707c8
Merge pull request #170 from chantca95/1.4_manual_testing
zioul123 3ae87ce
Edit diagram to add "alt" for bottom part of diagram
A19Sean 0fb5fc4
Merge pull request #149 from zioul123/v1.4-Documentation
A19Sean 487e625
Add return value from TagCommandParser
A19Sean ccadb3f
Fix Sequence Diagram
b5f45b7
Merge pull request #172 from A19Sean/tagcommand-sequence-diagram
AyushChatto 9509a42
fix Sequence Diagram
b3d4b28
Merge pull request #173 from AyushChatto/fixSequenceDiagram
chantca95 79bd8a3
fix Portfolio links
8a8e541
resize screenshots
chantca95 2e4689f
Merge pull request #174 from AyushChatto/fixPortfolioLinks
zioul123 6eb1110
Merge pull request #175 from chantca95/1.4_resize_screenshots
zioul123 4a05461
Update picture command sequence diagram.
denzelchung 1505103
Minor changes to ppp.
zioul123 97b93c0
resize and merge screenshot
chantca95 1cab4d2
Merge pull request #177 from denzelchung/pic-seq-diagram
chantca95 87c23d8
Add Manual Tests
1b48035
Merge pull request #178 from zioul123/Louiz-ppp
AyushChatto c7970a5
doc changes
chantca95 0dcd21f
Merge pull request #180 from AyushChatto/addManualTestsToDevGuide
chantca95 e6bab9a
Change the "do not use edit or delete" in tags to a recommendation.
zioul123 03a545e
Change conditions to lower case.
zioul123 8c8048a
Merge pull request #179 from chantca95/1.4_resize_screenshots
zioul123 d7f54ca
Update user-stories, use-case, nfrs and manual testing for tag comman…
A19Sean 8947dad
Fix github links.
zioul123 e728371
Merge master into update-dev-guide
A19Sean 6819c8a
Merge pull request #181 from zioul123/edit-delete-tags
AyushChatto cbda3a9
typo fix and make import sample screenshots bigger
chantca95 416fc22
Merge branch 'master' of https://github.com/CS2103-AY1819S1-W13-1/mai…
chantca95 d08a887
typo fix and make import sample screenshots bigger 2
chantca95 c41cc1a
Fix Typo in Portfolio
57f5aec
Update ppp.
zioul123 6d50e41
Merge pull request #183 from A19Sean/update-dev-guide
zioul123 74c99cb
Merge pull request #182 from zioul123/ModifyActivityDiagrams
chantca95 9746ae7
Update PPP
A19Sean f9645fb
Merge pull request #184 from chantca95/1.4_resize_screenshots
AyushChatto b6eaed5
Merge pull request #185 from AyushChatto/fixPortfolioTypo
chantca95 6101d26
Merge branch 'master' into a19sean-ppp
A19Sean fb0dda1
Merge pull request #186 from zioul123/ppp-update
AyushChatto 1e0ebcf
Merge branch 'master' into a19sean-ppp
A19Sean ffde06e
Fix typo
A19Sean 3946f53
Change image sizes.
zioul123 947750d
Change PPP to use real links
A19Sean caa8597
Merge pull request #188 from zioul123/ppp-update
AyushChatto 3664bf8
Merge branch 'master' into a19sean-ppp
A19Sean daeccc9
Merge pull request #187 from A19Sean/a19sean-ppp
zioul123 0a43536
Remove whitespace
068e150
Update Version Number
9005525
Merge pull request #189 from AyushChatto/deleteWhitespace
A19Sean ea49d45
Update ppp
A19Sean 49ac2e2
Merge pull request #190 from A19Sean/edit-a19sean-ppp
A19Sean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,9 @@ | ||
= Address Book (Level 4) | ||
= InsuRen | ||
ifdef::env-github,env-browser[:relfileprefix: docs/] | ||
|
||
https://travis-ci.org/se-edu/addressbook-level4[image:https://travis-ci.org/se-edu/addressbook-level4.svg?branch=master[Build Status]] | ||
https://ci.appveyor.com/project/damithc/addressbook-level4[image:https://ci.appveyor.com/api/projects/status/3boko2x2vr5cc3w2?svg=true[Build status]] | ||
https://coveralls.io/github/se-edu/addressbook-level4?branch=master[image:https://coveralls.io/repos/github/se-edu/addressbook-level4/badge.svg?branch=master[Coverage Status]] | ||
https://www.codacy.com/app/damith/addressbook-level4?utm_source=github.com&utm_medium=referral&utm_content=se-edu/addressbook-level4&utm_campaign=Badge_Grade[image:https://api.codacy.com/project/badge/Grade/fc0b7775cf7f4fdeaf08776f3d8e364a[Codacy Badge]] | ||
https://gitter.im/se-edu/Lobby[image:https://badges.gitter.im/se-edu/Lobby.svg[Gitter chat]] | ||
https://travis-ci.org/CS2103-AY1819S1-W13-1/main[image:https://travis-ci.org/CS2103-AY1819S1-W13-1/main.svg?branch=master[Build Status]] | ||
https://ci.appveyor.com/project/denzelchung/main-1gn9v/branch/master[image:https://ci.appveyor.com/api/projects/status/0cw1hdcgcqu31k9l/branch/master?svg=true[Build status]] | ||
https://coveralls.io/github/CS2103-AY1819S1-W13-1/main?branch=master[image:https://coveralls.io/repos/github/CS2103-AY1819S1-W13-1/main/badge.svg?branch=master[Coverage Status]] | ||
|
||
ifdef::env-github[] | ||
image::docs/images/Ui.png[width="600"] | ||
|
@@ -15,26 +13,33 @@ ifndef::env-github[] | |
image::images/Ui.png[width="600"] | ||
endif::[] | ||
|
||
* This is a desktop Address Book application. It has a GUI but most of the user interactions happen using a CLI (Command Line Interface). | ||
* It is a Java sample application intended for students learning Software Engineering while using Java as the main programming language. | ||
* It is *written in OOP fashion*. It provides a *reasonably well-written* code example that is *significantly bigger* (around 6 KLoC)than what students usually write in beginner-level SE modules. | ||
* What's different from https://github.com/se-edu/addressbook-level3[level 3]: | ||
** A more sophisticated GUI that includes a list panel and an in-built Browser. | ||
** More test cases, including automated GUI testing. | ||
** Support for _Build Automation_ using Gradle and for _Continuous Integration_ using Travis CI. | ||
'Ren' in Mandarin translates to 'person' or 'people', and true to our name, this app is all about managing one's | ||
network of clients in an organized, efficient and intuitive manner. InsuRen is geared to the needs of the modern | ||
Insurance salesman, but anyone whose business is their strong rapport with their clients will find this | ||
to be an indispensable tool. | ||
|
||
Managing one's clientele has never been easier! InsuRen is designed to be used | ||
without the hassle of a mouse, as users interact with their database purely through intuitive text commands. | ||
Some key features of our product include: | ||
|
||
* Adding tags to contacts and sorting contacts by tags. | ||
* Scheduling meetings for each contact and consolidating all meetings into a weekly timetable. | ||
* Keeping track of clients' payment dues. | ||
* Importing contacts from external databases and exporting the contacts in InsuRen's database. | ||
* And many more! | ||
|
||
== Site Map | ||
|
||
* <<UserGuide#, User Guide>> | ||
* <<DeveloperGuide#, Developer Guide>> | ||
* <<LearningOutcomes#, Learning Outcomes>> | ||
* <<AboutUs#, About Us>> | ||
* <<ContactUs#, Contact Us>> | ||
|
||
== Acknowledgements | ||
|
||
* Some parts of this sample application were inspired by the excellent http://code.makery.ch/library/javafx-8-tutorial/[Java FX tutorial] by | ||
_Marco Jakob_. | ||
* This project was evolved from the "AddressBook-Level4" project created by SE-EDU initiative at https://github.com/se-edu/ | ||
* Libraries used: https://github.com/TestFX/TestFX[TextFX], https://bitbucket.org/controlsfx/controlsfx/[ControlsFX], https://github.com/FasterXML/jackson[Jackson], https://github.com/google/guava[Guava], https://github.com/junit-team/junit5[JUnit5] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good job on : Adding UI Mockup |
||
|
||
== Licence : link:LICENSE[MIT] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"authors": [ | ||
{ | ||
"githubId": "A19Sean", | ||
"displayName": "AUYOK... SEAN", | ||
"authorNames": ["A19Sean", "Auyok Sean"] | ||
}, | ||
{ | ||
"githubId": "chantca95", | ||
"displayName": "CHAN ... ALEX", | ||
"authorNames": ["chantca95"] | ||
}, | ||
{ | ||
"githubId": "AyushChatto", | ||
"displayName": "CHATT...AYUSH", | ||
"authorNames": ["AyushChatto"] | ||
}, | ||
{ | ||
"githubId": "denzelchung", | ||
"displayName": "CHUNG...ENZEL", | ||
"authorNames": ["denzelchung"] | ||
}, | ||
{ | ||
"githubId": "zioul123", | ||
"displayName": "KIM-C...LOUIZ", | ||
"authorNames": ["zioul123"] | ||
} | ||
] | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job acknowledging AB4!