vi-mode: add gg/G motions and fix ^ motion behavior #953
+157
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juhan280
force-pushed
the
vi-mode
branch
5 times, most recently
from
72bcd81 to
0bcc73d
Compare
There is a bit of divergence in behaviour of `gg` and `G` motion of reedline and vim. In vim, these motion maintain the column position of the cursor, but reedline doesn't. Instead `gg` takes the cursor to the very first character and `G` takes to the very last character. Also when using these motion with a command, e.g. `c`, `d` and `y`, there are some inconsistency in handling the new line character due reedline not supporting line wise copy unlike vim. Added test case for `dgg`, `dG`, `cgg` and `cG` command.
Previously the `^` motion was behaving like the `0` motion which is to move the cursor to the start of the line. But in vim, the `^` motion is different from `0` motion. In vim `^` moved the cursor to the first non-blank character of the line. (See `:h ^`) Updated test case for `d^` and `c^` command since it has different behaviour now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ggandGmotions and adjusts the^motion invi-mode. Theggmotion moves the cursor to the first character of the buffer andGmoves it to the last. Unlike Vim, these motions do not keep the current column and their interaction with commands likec,d, andydiffers because reedline does not support linewise operations. Tests are included fordgg,dG,cgg, andcG.The
^motion now moves the cursor to the first non-blank character of the line instead of the line start. Test cases ford^andc^are updated accordingly.Also, the name
NonBlankStartcould be better. Please tell me if you come up with something better.This is the first pr I made in rust, if I did any mistake please point it out. Thanks