fix(tpc): support customizing dataLayer variable #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
harlan-zw
reviewed
Jul 23, 2024
This was referenced Jul 23, 2024
huang-julien
changed the title
use return type
harlan-zw
reviewed
Jul 25, 2024
scripts/generateTpcScripts.ts
Outdated
| returnStub: 'fn === \'dataLayer\' ? [] : void 0', | ||
| defaultOptions: { | ||
| dataLayerName: 'defaultGtm', | ||
| l: 'defaultGtm', |
There was a problem hiding this comment.
this should be undefined by default so we aren't adding it to the URL unless it's specified, we fallback to dataLayer for both GA and GTM
harlan-zw
reviewed
Jul 25, 2024
harlan-zw
reviewed
Jul 25, 2024
housseindjirdeh
approved these changes
Jul 25, 2024
|
waiting for GoogleChromeLabs/third-party-capital#59 (no breaking changes) to remove default options ( |
huang-julien
changed the title
huang-julien
changed the title
harlan-zw
approved these changes
Jul 30, 2024
harlan-zw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
With the latest and futur changes of TPC, it is better to make the API type of tpc composables depending on the return type of the use function instead of the API provided by TPC since it will differ for implementations reasons. This PR will also fixes a type issue with datalayer since it does not exist anymore in type provided by TPC (datalayers exist tho).
📚 Description