Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simulation step in the reset. #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

idigitopia
Copy link

We are using rigid_body_states to update the observation. however these are not updated till a simulation step happens. so technically we are getting wrong observations at every reset.

image

image

We are using rigid_body_states to update the observation. however these are not updated till a simulation step happens. so technically we are getting wrong observations at every reset.
Copy link
Collaborator

@xbpeng xbpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this will cause other issues. It will result in the environments being advanced two timesteps instead of one whenever one of the envs terminate, and only advancing one timestep when no envs terminate. We can't have that kind of randomness in the dynamics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants