implementation for set less than immediate #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2844 +/- ##
========================================
Coverage 71.98% 71.99%
========================================
Files 256 257 +1
Lines 60181 60801 +620
========================================
+ Hits 43324 43774 +450
- Misses 16857 17027 +170 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
sai/shift_right_arithmetic_immediate
to
master
December 16, 2024 10:00
| // slti: x[rd] = (x[rs1] < sext(immediate)) ? 1 : 0 | ||
| let local_rs1 = env.read_register(&rs1); | ||
| let local_imm = env.sign_extend(&imm, 12); | ||
| let rd_scratch = env.alloc_scratch(); |
There was a problem hiding this comment.
Sorry for being picky, but it would be nice to follow the convention of scope for the intermediary variables.
dannywillems
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.