-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[saffron] Add Diff type , methods, and tests #3006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81f6c60
to
fc74cdb
Compare
fc74cdb
to
4eca4ce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3006 +/- ##
==========================================
+ Coverage 76.80% 76.83% +0.03%
==========================================
Files 261 262 +1
Lines 61888 62028 +140
==========================================
+ Hits 47530 47662 +132
- Misses 14358 14366 +8 ☔ View full report in Codecov by Sentry. |
dannywillems
reviewed
Feb 9, 2025
73bfdde
to
297bf5b
Compare
@dannywillems 82bbc48 was added and PR description updated since original review |
297bf5b
to
ce258d3
Compare
…n the chunk size limit
ce258d3
to
82bbc48
Compare
dannywillems
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #3005
While working on #3004 I did not approach the
Diff
type carefully enough. This PR is meant to slow things down and make sure we have the spec fulfilled before implementing the update functionality that uses it.Diff
type and it's create method using sparse representation suggested by @dannywillems.Diff
spec. The assumptions are:test_allow_legal_updates
test_cannot_construct_bad_diff
Diff
specThe storage provider will also have to enforce these invariants