Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ruby tags focus and navigation #52

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: ruby tags focus and navigation #52

merged 2 commits into from
Jan 21, 2025

Conversation

viktar-dzmitryieu-tao
Copy link

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao commented Jan 9, 2025 •
edited
Loading

Ticket: https://oat-sa.atlassian.net/browse/INF-279

What's Changed

  • Fixed the focus and navigation issues appeared specifically for the Chrome (v. >=128)

How to test

  • Add any interaction in test item
  • Define prompt to it
  • Insert Furigana (Ruby) to any selection

Deployed to https://test-viktar-authoring.v3.playground.taocloud.org/tao/Main/login

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao requested review from a team, tikhanovichA, KirylHatalski and Karol-Stelmaczonek and removed request for a team January 9, 2025 14:29
@olga-kulish olga-kulish self-requested a review January 13, 2025 08:28
olga-kulish
olga-kulish approved these changes Jan 16, 2025
View reviewed changes
Copy link

@olga-kulish olga-kulish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well (checked Chrome only).
There are some issues when editing/removing ruby, but those are not related to original issue of this PR and are not critical.
Good job!

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao merged commit d44c6ba into develop Jan 21, 2025
@viktar-dzmitryieu-tao viktar-dzmitryieu-tao deleted the fix/INF-279/ruby-tags-focus-and-navigation branch January 21, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olga-kulish olga-kulish olga-kulish approved these changes

@bartlomiejmarszal bartlomiejmarszal bartlomiejmarszal approved these changes

@tikhanovichA tikhanovichA tikhanovichA approved these changes

@KirylHatalski KirylHatalski Awaiting requested review from KirylHatalski KirylHatalski was automatically assigned from oat-sa/fe-authoring

@Karol-Stelmaczonek Karol-Stelmaczonek Awaiting requested review from Karol-Stelmaczonek Karol-Stelmaczonek was automatically assigned from oat-sa/fe-authoring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viktar-dzmitryieu-tao @tikhanovichA @bartlomiejmarszal @olga-kulish