Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ruby tags focus and navigation #52

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: ruby tags focus and navigation #52

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf574d
fix: ruby tags focus and navigation
viktar-dzmitryieu-tao Jan 9, 2025
f98be7f
fix: remove line-breaking
viktar-dzmitryieu-tao Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions plugins/taofurigana/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ CKEDITOR.plugins.add('taofurigana', {
}
editor.fire( 'unlockSnapshot' );
return true;
}
}
}
/**
* Change command state according to the current selection content
Expand Down Expand Up @@ -181,7 +181,7 @@ CKEDITOR.plugins.add('taofurigana', {
setTimeout(function() {
setButtonsState(CKEDITOR.TRISTATE_DISABLED);
}, 150);

}
} else {
command.setState(CKEDITOR.TRISTATE_DISABLED);
Expand All @@ -206,7 +206,7 @@ CKEDITOR.plugins.add('taofurigana', {
rtElement = rubyElement.find('rt');
if (deleteRubyIfNoRt(startNode, true)) {
refreshCommandState(editor);
} else if (rbElement.$.length && rtElement.$.length && startNode.getParent().$ === rtElement.$[0] &&
} else if (rbElement.$.length && rtElement.$.length && startNode.getParent().$ === rtElement.$[0] &&
startNode.$.nextSibling === null && curRange.endOffset + 1 >= startNode.$.length) {
// if in the end of rt text
// move cursor outside ruby element
Expand All @@ -231,19 +231,32 @@ CKEDITOR.plugins.add('taofurigana', {
rbElement = new CKEDITOR.dom.element('rb', editor.document);
rbElement.append(getSelectionContent(selection));
rtElement = new CKEDITOR.dom.element('rt', editor.document);
brElement = new CKEDITOR.dom.element('br', editor.document);
olga-kulish marked this conversation as resolved.
Show resolved Hide resolved
rtElement.appendHtml(' ');
rubyElement.append(rbElement);
rubyElement.append(rtElement);

// create a temporary element for binding the cursor
anchor = new CKEDITOR.dom.element('span', editor.document);
rtElement.append(anchor);
rtElement.appendHtml(' ');

// add a <br> element for the better navigation in Chrome (version >= 128)
rtElement.append(brElement);

editor.insertElement(rubyElement);

// move cursor inside <rt>^</rt> Element
// move cursor inside the anchor
range = new CKEDITOR.dom.range(editor.document);
range.moveToElementEditablePosition(rtElement);
range.setStart(anchor, 0);
range.collapse(true);
editor.getSelection().removeAllRanges();
editor.getSelection().selectRanges([range]);
refreshCommandState(editor);

editor.fire( 'unlockSnapshot' );
// remove anchor
anchor.remove();
}
}
});
Expand Down