new lint: added enum_variant_deprecated
#1095
Conversation
|
hey @obi1kenobi can yu re run the ci once? the test is passing locally |
|
looks like you need to update the snapshot or you changed the test dir and didnt commit? |
obi1kenobi
changed the title
enum_variant_depreciatedenum_variant_deprecated
| _ => { /* ... */ } | ||
| }"# | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Please configure your text editor to always add a trailing newline to all files, and ensure all files in the PR have trailing newlines.
| variant { | ||
| variant_name: name @output @tag | ||
| deprecated @filter(op: "=", value: ["$true"]) | ||
| span_: span @optional { | ||
| filename @output | ||
| begin_line @output | ||
| } | ||
| } |
There was a problem hiding this comment.
This block needs a public_api_eligible check, both here and on the baseline side.
Otherwise, this lint will flag variants that were #[doc(hidden)] in the baseline, which is incorrect since they weren't public API.
Relevant docs here:
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/rustdoc-v39/src/rustdoc_schema.graphql#L91-L110
Please make sure to also add tests for #[doc(hidden)] enums and variants, to make sure those are never flagged by this lint.
| required_update: Minor, | ||
| lint_level: Deny, | ||
| reference_link: Some("https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute"), | ||
| query: r#" |
There was a problem hiding this comment.
nit: This query is a bit hard to read — it's very dense. Take a look at how other lints format queries, and try to follow their example. For example, you can use blank lines to break up blocks into smaller, more digestible chunks.
|
@Gmin2 just checking if you're still interested in driving your two PRs to completion. No worries if you're too busy with other things, I just wanted to know one way or the other. |
|
i was occupied with my uni exams, will able to complete this by eow only, if its urgent yu can close it |
|
EOW is fine, just wanted to make sure it's still on your radar and not dropped :) Good luck with exams! |
|
Going to close this for inactivity for now, just to un-claim the issue it's attached to. If you get a chance to come back to it and complete it, feel free to reopen the PR. Hope all is well! |
part of #57