Add lint declarative_macro_missing

[miikka]

Working to implement the first item in #946: "removing a declarative macro that used to exist".

There's this case as well, but I'm not sure if it can be currently queried for:

#[macro_export]
macro_rules! inner_pub_use_will_be_removed {
    () => {};
}

pub mod inner {
    // Is it a breaking change if you remove the next line?
    pub use crate::inner_pub_use_will_be_removed;
}

[miikka]

Not sure how to address the beta failure...

The referenced type does not exist in the schema: Macro

[obi1kenobi]

It might need a `cargo update` to pick up the latest schema.

…

On Sun, Oct 13, 2024, 9:03 AM Miikka Koskinen ***@***.***> wrote: Not sure how to address the beta failure... The referenced type does not exist in the schema: Macro — Reply to this email directly, view it on GitHub <#966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5MSTXYPY4FW77VUXYJW3Z3ILMZAVCNFSM6AAAAABPWUUBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHA2TGOBRGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[miikka]

I tried cargo update and it didn't help. I assume the point would be to update the versions of trustfall-rustdoc-adapter? It didn't touch the versions of any of those.

[obi1kenobi]

Hmm interesting, I might have messed something up then. I'll take a look when I get back home later this week, sorry about that.

…

On Sun, Oct 13, 2024, 10:18 AM Miikka Koskinen ***@***.***> wrote: I tried cargo update and it didn't help. I assume the point would be to update the versions of trustfall-rustdoc-adapter? It didn't touch the versions of any of those. — Reply to this email directly, view it on GitHub <#966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5MSQAXNS7RGUUQBBFZB3Z3IUELAVCNFSM6AAAAABPWUUBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHA3TQNRVGE> . You are receiving this because you commented.Message ID: ***@***.***>

[obi1kenobi]

My bad, I got everything ready then just failed to cut the release 🙈 I'll have a new release up momentarily, and I'll take care of updating your PR to merge it to so I can atone for sending you down a debugging rabbit hole unnecessarily...

Excellent catch on re-exporting macros as well! To my surprise, re-exporting does seem to work: playground

#[macro_export]
macro_rules! inner_pub_use_will_be_removed {
    () => {};
}

pub mod inner {
    /// We can re-export macros at non-root paths, watch:
    /// ` ``rust
    /// use playground::inner::inner_pub_use_will_be_removed;
    ///
    /// inner_pub_use_will_be_removed! {}
    /// ` ``
    pub use crate::inner_pub_use_will_be_removed;
}

I've opened #968 to track this issue, which you are also welcome to grab if you're interested!

[obi1kenobi]

Thanks for putting this together, and for the great ideas on how to test macros further!

Accepting with minor tweaks, which I'll apply since I feel bad for making you debug why the macro queries weren't working 😅

[obi1kenobi]

Excellent diagnostic, I forgot that removing #[macro_export] is a way to cause breakage here! 🎉

[obi1kenobi]

The v33 rustdoc JSON adapter release was also broken due to a failure of my release automation. Whew, thank goodness for good CI that prevented the merge, or else it would have been a prod break 😅