Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR protoplasmic astrocytes fibrous astrocytes interlaminar astrocytes #2331

Conversation

AvolaAmg
Copy link
Collaborator

@AvolaAmg AvolaAmg commented Apr 9, 2024

@dosumis
Copy link
Contributor

dosumis commented Apr 9, 2024

#gogoeditdiff

Copy link

github-actions bot commented Apr 9, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-04-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-04-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4042007 http://purl.obolibrary.org/obo/CL_4042007

Added

CL_4042008 http://purl.obolibrary.org/obo/CL_4042008

Added

CL_4042009 http://purl.obolibrary.org/obo/CL_4042009

Added

CL_4042010 http://purl.obolibrary.org/obo/CL_4042010

Added

CL_4042011 http://purl.obolibrary.org/obo/CL_4042011

Added

Copy link

github-actions bot commented Apr 9, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4042007 http://purl.obolibrary.org/obo/CL_4042007

Added

CL_4042008 http://purl.obolibrary.org/obo/CL_4042008

Added

CL_4042009 http://purl.obolibrary.org/obo/CL_4042009

Added

CL_4042010 http://purl.obolibrary.org/obo/CL_4042010

Added

CL_4042011 http://purl.obolibrary.org/obo/CL_4042011

Added

Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add part relationships (e.g. to cortex). Should be able to get some inferred classification from these. (Note: This looks like a case where has_soma_location would be useful, but this is currently restricted to neurons).

Besides that- please see minor correction/suggestions to text

(I'm also seeing something odd with APs in robot diffs. Investigating)

@dosumis
Copy link
Contributor

dosumis commented Apr 9, 2024

@anitacaron - is there something odd going on with the ROBOT diff? I'm seeing different APs on ROBOT diff vs functional syntax text diff

e.g.

CL_4042009 comment "An astrocyte type that presents radial protrusions across the layers of a cortex. The soma of this astrocyte is part of the first layer of a neocortex. This astrocyte extents its protrusions transversally to the deeper layers of a cortex and it creates contact with neurons, a pia matter and capillaries. This astrocyte is involved in facilitating the communication across neurons, astrocytes, capillaries, meninges and the cerebrospinal fluid."

vs:

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:19279265") Annotation(oboInOwl:hasDbXref "PMID:30552685") Annotation(oboInOwl:hasDbXref "PMID:31435019") Annotation(oboInOwl:hasDbXref "PMID:32930323") Annotation(oboInOwl:hasDbXref "PMID:34616062") Annotation(oboInOwl:hasDbXref "PMID:37824655") obo:IAO_0000115 obo:CL_4042009 "An astrocyte type that presents radial protrusions across the layers of a cortex. The soma of this astrocyte is part of the first layer of a neocortex. This astrocyte extents its protrusions transversally to the deeper layers of a cortex and it creates contact with neurons, the pia matter and capillaries. This astrocyte is involved in facilitating the communication across neurons, astrocytes, capillaries, meninges and the cerebrospinal fluid.")

IAO_0000115 = definition

Looks correct on loading in Protege.

image

@AvolaAmg
Copy link
Collaborator Author

AvolaAmg commented Apr 9, 2024

#gogoeditdiff

@dosumis
Copy link
Contributor

dosumis commented Apr 10, 2024

@JABelfiore can you review text on this PR? Given your Comms background I'm hoping you might be able to help polish/subedit definitions and comments.

dosumis
dosumis previously approved these changes Apr 11, 2024
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make minor changes in text before merge. Thanks!

@AvolaAmg AvolaAmg requested a review from JABelfiore April 15, 2024 09:51
@AvolaAmg AvolaAmg merged commit 4012adf into master Apr 15, 2024
1 check passed
@AvolaAmg AvolaAmg deleted the NTR-protoplasmic-astrocyte-fibrous-astrocyte-interlaminar-astrocyte branch April 15, 2024 10:23

# Class: obo:CL_4042008 (fibrous astrocyte)

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:19279265") Annotation(oboInOwl:hasDbXref "PMID:22144298") Annotation(oboInOwl:hasDbXref "PMID:28280934") Annotation(oboInOwl:hasDbXref "PMID:31435019") Annotation(oboInOwl:hasDbXref "PMID:34616062") obo:IAO_0000115 obo:CL_4042008 "A cell type located in the first layer of the neocortex with radial protrusions extending transversely into the deeper cortex layers, herby facilitating communication across neurons, astrocytes, capillaries, meninges and cerebrospinal fluid through contact with neurons, pia mater and capillaries.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to change "A cell type..." to "An astrocyte..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants