-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR protoplasmic astrocytes fibrous astrocytes interlaminar astrocytes #2331
NTR protoplasmic astrocytes fibrous astrocytes interlaminar astrocytes #2331
Conversation
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsCL_4042007
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsCL_4042007
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add part relationships (e.g. to cortex). Should be able to get some inferred classification from these. (Note: This looks like a case where has_soma_location would be useful, but this is currently restricted to neurons).
Besides that- please see minor correction/suggestions to text
(I'm also seeing something odd with APs in robot diffs. Investigating)
@anitacaron - is there something odd going on with the ROBOT diff? I'm seeing different APs on ROBOT diff vs functional syntax text diff e.g. CL_4042009 comment "An astrocyte type that presents radial protrusions across the layers of a cortex. The soma of this astrocyte is part of the first layer of a neocortex. This astrocyte extents its protrusions transversally to the deeper layers of a cortex and it creates contact with neurons, a pia matter and capillaries. This astrocyte is involved in facilitating the communication across neurons, astrocytes, capillaries, meninges and the cerebrospinal fluid." vs: AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:19279265") Annotation(oboInOwl:hasDbXref "PMID:30552685") Annotation(oboInOwl:hasDbXref "PMID:31435019") Annotation(oboInOwl:hasDbXref "PMID:32930323") Annotation(oboInOwl:hasDbXref "PMID:34616062") Annotation(oboInOwl:hasDbXref "PMID:37824655") obo:IAO_0000115 obo:CL_4042009 "An astrocyte type that presents radial protrusions across the layers of a cortex. The soma of this astrocyte is part of the first layer of a neocortex. This astrocyte extents its protrusions transversally to the deeper layers of a cortex and it creates contact with neurons, the pia matter and capillaries. This astrocyte is involved in facilitating the communication across neurons, astrocytes, capillaries, meninges and the cerebrospinal fluid.") IAO_0000115 = definition Looks correct on loading in Protege. |
#gogoeditdiff |
…te-interlaminar-astrocyte
@JABelfiore can you review text on this PR? Given your Comms background I'm hoping you might be able to help polish/subedit definitions and comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make minor changes in text before merge. Thanks!
…ar-astrocyte' of https://github.com/obophenotype/cell-ontology into NTR-protoplasmic-astrocyte-fibrous-astrocyte-interlaminar-astrocyte
…te-interlaminar-astrocyte
|
||
# Class: obo:CL_4042008 (fibrous astrocyte) | ||
|
||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:19279265") Annotation(oboInOwl:hasDbXref "PMID:22144298") Annotation(oboInOwl:hasDbXref "PMID:28280934") Annotation(oboInOwl:hasDbXref "PMID:31435019") Annotation(oboInOwl:hasDbXref "PMID:34616062") obo:IAO_0000115 obo:CL_4042008 "A cell type located in the first layer of the neocortex with radial protrusions extending transversely into the deeper cortex layers, herby facilitating communication across neurons, astrocytes, capillaries, meninges and cerebrospinal fluid through contact with neurons, pia mater and capillaries.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to change "A cell type..." to "An astrocyte..."
Fixes #2320 #2321 #2322 #2328