Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise endometrial ciliated epithelial cells classification and add links to GO terms #2440

Merged

Conversation

Caroline-99
Copy link
Collaborator

@Caroline-99 Caroline-99 commented Jul 18, 2024

Revise endometrial ciliated epithelial cells classification and add links to GO terms

…s to GO terms

An ongoing PR for cleaning up ciliated epithelial cells hierarchy and links to GO terms

- Imported GO terms into CL:
  - GO:0097730 (non-motile cilium)
  - GO:0036126 (sperm flagellum)
@Caroline-99 Caroline-99 linked an issue Jul 18, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Jul 18, 2024
@Caroline-99 Caroline-99 marked this pull request as draft July 18, 2024 08:43
…lial cell

- Updated logical and textual definition of endometrial ciliated epithelial cell.
-Included links to GO terms
- Added references to support that endometrial ciliated epithelial cell are multi-ciliated cells
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

Copy link

Your branch is 3 commit/s behind, please update your branch.

@Caroline-99 Caroline-99 marked this pull request as ready for review July 22, 2024 10:58
@Caroline-99 Caroline-99 changed the title Clean up ciliated epithelial cells hierarchy and links to GO terms Clean up endometrial ciliated epithelial cells classification and add links to GO terms Jul 22, 2024
@Caroline-99 Caroline-99 changed the title Clean up endometrial ciliated epithelial cells classification and add links to GO terms Revise endometrial ciliated epithelial cells classification and add links to GO terms Jul 22, 2024
@dosumis
Copy link
Contributor

dosumis commented Jul 23, 2024

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-07-23/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-07-23/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030040

Removed

Added

glandular endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030042

Removed

Added

luminal endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030041

Removed

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030040

Removed

Added

glandular endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030042

Removed

Added

luminal endometrial ciliated epithelial cell http://purl.obolibrary.org/obo/CL_4030041

Removed

Added

@Caroline-99 Caroline-99 requested a review from aleixpuigb July 23, 2024 10:26
…and links to GO terms"

This reverts commit f946491.
Reason, GO terms to be imported were not added.
aleixpuigb
aleixpuigb previously approved these changes Jul 23, 2024
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@dosumis
Copy link
Contributor

dosumis commented Jul 23, 2024

Related #2460

@dosumis dosumis added this to the Sprint 22/07/24 milestone Jul 23, 2024
- Imported  GO:0097729 - 9+2 motile cilium
- Updated logical definition
- Updated textual definition and added reference to support 9+2 motile cilia
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see inline comments.

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@Caroline-99 Caroline-99 merged commit 2f18f6a into master Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Links to GO terms for types of cilia and villi
3 participants