-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting differences in ontology files (attempt 2) #9856
Conversation
@matentzn : Currently This is the |
Can you clarify what you mean? What example do you need from me? |
What do you expect as the markdown. Is there a release note from some other ontology you want to mimic? As of now |
I think something like the Mondo release notes is a great starting point! |
Pausing on this for some time. Relevant PR in |
@pnrobinson are you asking because you want to clean PRs or because this is becoming a higher priority for you? This is currently not a priority for us; |
This is more of a new years resolution (zero issue inbox) than a high priority issue. |
So I did a thoughts @matentzn @pnrobinson ? Overview
Nodes Deleted
Synonyms Removed
Node Renamed
Edges Deleted
Nodes Moved
Node Text Definition Changed
Node Unobsoleted
New Synonyms Added
|
@hrshdhgd I know this is super annoying but can you:
Thanks a ton, this is a very important thing to get right, and therefore I need a better way to provide feedback than what GitHub can give me now. |
replaced your doc by https://docs.google.com/document/d/1ipDbH4OdhRYUPNHsnwI8uDc1BbXomOBOhxxktqvukFk/edit |
New formatClass Created: 222
Node Renamed: 49
Node Text Definition Changed: 26
Node Direct Merge: 13
Node Obsoleted with Direct Replacement: 1
New Synonyms Added: 65
Synonyms Removed: 8
New Text Definition: 6500
Updated google doc |
Just noticed |
Classes created: 222
Nodes renamed: 49
Text definitions changed: 26
Nodes direct merge: 13
Nodes obsoleted with direct replacement: 1
Synonyms added: 65
Synonyms removed: 8
Text definitions added: 2
|
Super! Thanks! |
@pnrobinson thanks - there are some smaller more tweaks we want to do here, I will ping you when its ready for review! |
Classes created: 1885
Other nodes created: 9
Nodes deleted: 306
Nodes obsoleted: 524
Nodes obsoleted with replacement: 58
Nodes renamed: 163
Text definitions changed: 802
Synonyms added: 6866
Synonym predicates changed: 265
Synonyms removed: 469
Text definitions added: 35
|
Latest iteration. Classes added: 222
Nodes merged: 13
Nodes obsoleted with replacement: 1
Nodes renamed: 32
Text definitions changed: 26
Text definitions added: 2
Mappings removed: 4
Synonyms added: 65
Synonyms removed: 6
Edges removed: 41
New relationships added: 29
|
@hrshdhgd this looks awesome.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not reviewing yet because there is still one larger issue in here that needs to be sorted out. There are two possible, but completely distinct ways to run the diff:
- branch-local. The strategy is this: You stay on the branch (never switch), download the edit file and preocess it as a seperate make goal, like
tmp/hp-branch.owl
. Then you compare this to the corresponding local file, like hp.owl. - across-branch. The strategy is this. You checkout the
master
branch, run themake ontology.owl
cache the file (for example in GitHub actions, as you do), then switch to thebranch
, run themake ontology.owl
command again, cache the result. Then you compare the two cached results.
For the GitHub action, we should go with (2), as you mostly do. This means though that all these make
goals that depend on an hp-edit that is downloaded from the master branch should be removed from the Makefile
(not (!) the commands for the release diff!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - there is one small bug, and I made a few changes. Can you test if the action still works?
All workflows pass! |
Relationships removed: 4
Synonyms removed: 1
Nodes removed: 1
Text definitions removed: 1
|
Continued from #9601
Do not merge until:
oaklib
is released