Create release notes markdown output for diff command
#605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 76.07% 75.95% -0.13%
==========================================
Files 262 264 +2
Lines 30388 30682 +294
==========================================
+ Hits 23118 23303 +185
- Misses 7270 7379 +109 ☔ View full report in Codecov by Sentry. |
|
Made the suggested changes. Also added mapping (changes + addition + deletion)
Classes created: 126
Other nodes created: 1
Nodes obsoleted without replacement: 12
Nodes obsoleted with replacement: 7
Nodes renamed: 8
Text definitions changed: 7
Text definitions added: 2
Mappings created: 30
Mappings deleted: 21
Mappings changed: 14
Synonyms added: 121
Synonyms removed: 23
Synonym predicates changed: 14
Edges deleted: 165
Nodes moved: 129
Predicates changed: 6
|
|
Aweeesome!! This is really looking pretty! More feedback (hope I am not getting on your nerves)
|
Not yet! 😄
Done
Me neither, maybe @cmungall could enlighten us!
Ok, commented code out. You can use any of the 2 issues I mentioned above. Classes created: 126
Other nodes created: 1
Nodes obsoleted without replacement: 12
Nodes obsoleted with replacement: 7
Nodes renamed: 8
Text definitions changed: 7
Text definitions added: 2
Mappings created: 30
Mappings deleted: 21
Synonym predicates changed: 14
Synonyms added: 121
Synonyms removed: 23
Edges deleted: 165
Nodes moved: 129
Predicates changed: 6
|
|
I think thats it. When you get an answer from Chris on what the "nodes moved" thing is doing (to me, it seems some crucial information is missing), also just do me a small favour and harmonise the added/created--removed/deleted terminology a bit (I would just do added and removed anywhere), but this is minor and can be done in the future. Approved! |
|
@matentzn , dug through the code and came to a conclusion that Classes added: 126
Other nodes added: 1
Nodes obsoleted without replacement: 12
Nodes obsoleted with replacement: 7
Nodes renamed: 8
Text definitions changed: 7
Text definitions added: 2
Mappings added: 30
Mappings removed: 21
Synonyms added: 121
Synonym predicates changed: 14
Synonyms removed: 23
Edges removed: 165
New relationships added: 129
Predicates changed: 6
|
cmungall
reviewed
Mar 12, 2024
cmungall
approved these changes
Mar 12, 2024
|
For any questions about KGCL the best place is the KGCL issue tracker, you can look up any Change class like this kgcl:NodeMove |
|
cmungall
added a commit
that referenced
this pull request
Mar 18, 2024
* Adding a more efficient diff implementation for simpleobo. Undoing some of #605 * ruffruff * fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to obophenotype/human-phenotype-ontology#9856
Wait to merge until INCATools/kgcl#54 merged and KGCL released