Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axioms on uncinate fasciculus and added disjoint for brainstem #2343

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

shawntanzk
Copy link
Collaborator

Fixes #2341 (change part of to overlaps, and added a whole bunch of overlaps that is in the textual definition but not in logical definition)
Fixes #2342

Fixes #2341 (change part of to overlaps, and added a whole bunch of overlaps that is in the textual definition but not in logical definition)
Fixes #2342
relationship: overlaps UBERON:0002275 ! reticular formation
relationship: overlaps UBERON:0002298 ! brainstem
relationship: overlaps UBERON:0002726 ! cervical spinal cord
relationship: overlaps UBERON:0003023 {source="NIFSTD"} ! pontine tegmentum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawntanzk I'd remove the NIFSTD source, because it's not the source of this overlaps rel.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was there on the part_of relation from before - I wonder if it shows provenance? cause the definition doesn't mention pons/pontine tegmentum at all. Will try to look into NIFSTD to check this, if not find why this is there from literature

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth keeping as NIFSTD is at least the source of a partonomy relationship, even if they didn't choose the right one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok trying to open NIF on protege is killing it lol, im going to assume that the partonomy relationship is there (don't see partonomy relationships in general on bioportal where the user facing nif is at) - either way, since it was there before I think it should be kept

Copy link
Contributor

@paolaroncaglia paolaroncaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawntanzk I added a comment. Other than that, all looks good to me and ready to merge.

@shawntanzk shawntanzk merged commit 3b728da into master Mar 10, 2022
@shawntanzk shawntanzk deleted the fix-uncinate-fasciculus branch March 10, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants