Default Calendar Sources for renderCalendar + Cache Bugfix (NonBreaking Option) #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarekbird
force-pushed
the
jarekbird/non_breaking_change_bugfix
branch
from
ecf0669
to
26d50e7
Compare
jarekbird
commented
May 24, 2023
| ```dataviewjs | ||
| this.container.style.minHeight = "500px"; | ||
| const { renderCalendar, initializeSettings } = app.plugins.plugins["obsidian-full-calendar"]; | ||
| await initializeSettings(); |
There was a problem hiding this comment.
This is a non breaking change, but the user is required to manually call initializeSettings(); from the dataview to solve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative bugfix solution to this PR: #456