Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AST section to examples #545

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pedrobslisboa
Copy link

@pedrobslisboa pedrobslisboa commented Dec 15, 2024

41 files where: 20 are pngs and 8 are old examples files deleted. So don't be scared

Captura de Tela 2024-12-15 às 19 11 58
Captura de Tela 2024-12-15 às 19 12 57

Description

This is the first part of adding the ppx-by-example to ppxlib
I will divide it into PR so we can review it better, focusing on the explanation and typos without having tons of files to review. It is really necessary that this section is easy to understand and is aligned with ppxlib.
@NathanReb Can you create a ppx-by-example base branch? So I can point this one to it, and after all merges (Other sections) on this branch, we move with the entire ppx-by-example branch to main?

AST

This PR adds the AST sections AST / Building ASTs / Destructing ASTs

How to test it (It's important to check it not only by code but also as styles)

  • At this branch run
     make doc
     open _build/default/_doc/_html/ppxlib/index.html
  • Access Examples
  • Access each section:
    • AST
    • Building an AST
    • Destructing an AST

@pedrobslisboa pedrobslisboa marked this pull request as ready for review December 15, 2024 22:07
@pedrobslisboa pedrobslisboa mentioned this pull request Dec 15, 2024
2 tasks
@pedrobslisboa pedrobslisboa force-pushed the examples/ast branch 4 times, most recently from 62d3fb9 to 6a2f1e9 Compare December 15, 2024 23:24
Signed-off-by: Pedro B S Lisboa <[email protected]>
Signed-off-by: Pedro B S Lisboa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant