Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ocamlformat 0.26.0 #979

Closed
wants to merge 3 commits into from
Closed

Upgrade to ocamlformat 0.26.0 #979

wants to merge 3 commits into from

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Jun 27, 2023

The aim of this commit is to gather feedback.

Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

@Julow Julow marked this pull request as draft June 27, 2023 16:49
jonludlam
jonludlam reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@jonludlam jonludlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, with that one exception.

doc/examples/markup.mli Outdated Show resolved Hide resolved
src/document/url.ml Show resolved Hide resolved
@Julow Julow mentioned this pull request Jun 28, 2023
Closed
@Julow Julow force-pushed the preview-ocamlformat-0.26.0 branch from f42fd06 to b9a7c5b Compare July 10, 2023 10:13
@Julow
Copy link
Collaborator Author

Julow commented Jul 10, 2023

I updated the preview with the bugs fixed.
Is the .git-blame-ignore-revs file a welcome addition ?

@trefis
Copy link
Contributor

trefis commented Jul 17, 2023 •
edited
Loading

Is the .git-blame-ignore-revs file a welcome addition ?

Yes!

@Julow Julow force-pushed the preview-ocamlformat-0.26.0 branch from 7480033 to 9e66661 Compare July 18, 2023 09:19
@Julow Julow force-pushed the preview-ocamlformat-0.26.0 branch from 9e66661 to 79b2e7f Compare July 20, 2023 10:24
@Julow
.ocamlformat: Specify ocaml-version
07800cb 
Make sure that OCamlformat won't generate syntaxes that are not
recognized by OCaml 4.02.
@Julow Julow changed the title Preview: Upgrade to ocamlformat 0.26.0 (unreleased) Upgrade to ocamlformat 0.26.0 Jul 20, 2023
@Julow
Copy link
Collaborator Author

Julow commented Jul 20, 2023

OCamlformat 0.26.0 has been released! This PR can be merged (not squashed due to .git-blame-ignore-revs) or closed if it's a bit too early to upgrade.

@Julow Julow marked this pull request as ready for review July 20, 2023 10:33
gpetiot
gpetiot approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@Julow
Copy link
Collaborator Author

Julow commented Sep 5, 2023

OCamlformat will be released with compatibility with 5.1 in a few weeks. Let's skip 0.26.0.

@Julow Julow closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonludlam jonludlam jonludlam left review comments

@gpetiot gpetiot gpetiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julow @trefis @jonludlam @gpetiot