cOdiglet to use criwrapper to create ic #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
298dd4b to
613ebf4
Compare
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
7311ce9 to
b2978f7
Compare
edeNFed
reviewed
Dec 17, 2024
| runtimeDetailsByContainer: | ||
| description: Capture Runtime Details for the workloads that this CR | ||
| applies to. | ||
| items: | ||
| properties: | ||
| containerName: | ||
| type: string | ||
| criErrorMessage: |
There was a problem hiding this comment.
isnt status a better place for error messages instead of spec?
There was a problem hiding this comment.
potentially could be some error on specific container, we will have to verify this before instrumenting a container from the webhook
edeNFed
reviewed
Dec 17, 2024
k8sutils/pkg/cri/criwrapper.go
Outdated
| for _, endpoint := range defaultRuntimeEndpoints { | ||
| rc.Logger.Info("Attempting to connect to CRI runtime", "endpoint", endpoint) | ||
|
|
||
| rc.conn, err = grpc.NewClient( |
There was a problem hiding this comment.
Are you sure this is actually trying to connect and not just creating a client?
Few thoughts:
- As only one of the default Endpoints will respond - maybe worth putting a timeout when opening a connection as some of them will just time out so we can bail quickly
- I think the CRI implementation is part of the container id in Kubernetes maybe we can use that (for example getting the container id of the current Odiglet Pod) and connector only to the right one instead of trying all the options
There was a problem hiding this comment.
- I Warp it up as a Connect() - The function’s primary purpose is to connect to the CRI runtime, which it achieves by establishing and validating a gRPC connection.
I change the logic so it will try to find the unix domain socket in the FS so we wont need to iterate over them and try to connect to each one of them
edeNFed
reviewed
Dec 17, 2024
edeNFed
reviewed
Dec 17, 2024
edeNFed
reviewed
Dec 17, 2024
| } | ||
|
|
||
| // Check if status is already set | ||
| if len(currentConfig.Status.RuntimeDetailsByContainer) != 0 { |
There was a problem hiding this comment.
Why not update always? This means only the first Odiglet that runs this wins, so we will not update the value if the user changed the docker image?
There was a problem hiding this comment.
correct, it wont work with cases where user changed the value exists in Dockerfile.
we design this solution with this gap in mind
RonFed
reviewed
Dec 17, 2024
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
71831ff to
1c14d62
Compare
blumamir
reviewed
Dec 22, 2024
odiglet/pkg/kube/runtime_details/instrumentationconfigs_controller.go
Outdated
Show resolved
Hide resolved
…ting over multiple pods
blumamir
approved these changes
Dec 23, 2024
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
ca8cee9 to
05e1f53
Compare
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
975c7f3 to
c679274
Compare
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
abdb8d1 to
717dfb7
Compare
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
7acfbac to
bd9bf89
Compare
RonFed
reviewed
Dec 25, 2024
tamirdavid1
force-pushed
the
odiglet-to-use-criwrapper-to-create-ic
branch
from
bb3f5ef to
80737f1
Compare
RonFed
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.